Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752708AbeACOJ1 (ORCPT + 1 other); Wed, 3 Jan 2018 09:09:27 -0500 Received: from mx2.suse.de ([195.135.220.15]:55482 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752553AbeACOJZ (ORCPT ); Wed, 3 Jan 2018 09:09:25 -0500 Date: Wed, 3 Jan 2018 15:09:23 +0100 From: Michal Hocko To: Anshuman Khandual Cc: Andrew Morton , Zi Yan , Naoya Horiguchi , "Kirill A. Shutemov" , Vlastimil Babka , Andrea Reale , linux-mm@kvack.org, LKML Subject: Re: [PATCH 2/3] mm, migrate: remove reason argument from new_page_t Message-ID: <20180103140923.GD11319@dhcp22.suse.cz> References: <20180103082555.14592-1-mhocko@kernel.org> <20180103082555.14592-3-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed 03-01-18 19:30:38, Anshuman Khandual wrote: > On 01/03/2018 01:55 PM, Michal Hocko wrote: > > From: Michal Hocko > > > > No allocation callback is using this argument anymore. new_page_node > > used to use this parameter to convey node_id resp. migration error > > up to move_pages code (do_move_page_to_node_array). The error status > > never made it into the final status field and we have a better way > > to communicate node id to the status field now. All other allocation > > callbacks simply ignored the argument so we can drop it finally. > > There is a migrate_pages() call in powerpc which needs to be changed > as well. It was failing the build on powerpc. Yes, see http://lkml.kernel.org/r/20180103091134.GB11319@dhcp22.suse.cz -- Michal Hocko SUSE Labs