From: Markus <M4rkusXXL@web.de>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>
Subject: Re: objtool segfault with ORC unwinder enabled
Date: Wed, 03 Jan 2018 15:14:55 +0100
Message-ID: <1659502.tmOLjC0cqW@markus>
In-Reply-To: <20180103135924.ajpb5kslhkwtd5gb@treble>
References: <1537667.mbZVOcHbLR@markus> <1954665.Z2ZbY5be2g@markus> <20180103135924.ajpb5kslhkwtd5gb@treble>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="nextPart2431370.87AU1eJE5D"
Content-Transfer-Encoding: 7Bit
Sender: linux-kernel-owner@vger.kernel.org

This is a multi-part message in MIME format.

--nextPart2431370.87AU1eJE5D
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

On Wed, Jan 03, 2018 at 14:59:24 CET Josh Poimboeuf wrote:
> On Wed, Jan 03, 2018 at 01:22:07PM +0100, Markus wrote:
> > On Wed, Jan 03, 2018 at 12:19:41 CET Greg Kroah-Hartman wrote:
> > > On Wed, Jan 03, 2018 at 11:49:08AM +0100, Markus wrote:
> > > > Hello!
> > > > 
> > > > ORC unwinder is enabled in stable for wider testing but still at least
> > > > one
> > > > bug is open:
> > > > https://bugzilla.kernel.org/show_bug.cgi?id=197035
> > > 
> > > Random web links on mailing lists don't help much, please put the
> > > information here in the email.
> > 
> > Its not a random web link. Its the official kernel.org bugtracker. But
> > nobody seems to be looking at it.
> > 
> > > > objtool will segfault because a NULL pointer is dereferenced.
> > > 
> > > And how are you reproducing this?
> > 
> > Just building the kernel with ORC enabled.
> > (At least for me. Using framepointers compiles, enabling ORC again breaks
> > it.) gcc 6.4.0 (In bug report others were tested as well.)
> > elfutils 0.170
> > What else may be interesting?
> > 
> > > > Is a NULL pointer sym valid?
> > > > If a NULL pointer is invalid, it has to be checked why it is sometimes
> > > > NULL.
> > > 
> > > What .config is triggering this problem?
> > 
> > See attachment.
> > 
> > > And does this show up on 4.14.11, and 4.15-rc6?
> > 
> > Both: yes.
> > 
> > /tools/objtool/objtool orc generate --no-fp "arch/x86/kernel/irq.o"
> > 
> > => segfault.
> > 
> > Changing CFLAGS for objtool to O1 and starting from gdb:
> > 
> > (gdb) r orc generate --no-fp "arch/x86/kernel/irq.o"
> > Starting program: tools/objtool/objtool orc generate --no-fp
> > "arch/x86/kernel/ irq.o"
> > 
> > Program received signal SIGSEGV, Segmentation fault.
> > 0x000055555555e06c in elf_rebuild_rela_section
> > (sec=sec@entry=0x7ffff690d010) at elf.c:554
> > 554                     relas[idx].r_info = GELF_R_INFO(rela->sym->idx,
> > rela-> 
> > >type);
> > 
> > (gdb) bt
> > #0  0x000055555555e06c in elf_rebuild_rela_section
> > (sec=sec@entry=0x7ffff690d010) at elf.c:554
> > #1  0x000055555555d0aa in create_orc_sections
> > (file=file@entry=0x7ffffff7d740) at orc_gen.c:210
> > #2  0x000055555555c146 in check (_objname=<optimized out>,
> > _no_fp=<optimized out>, no_unreachable=<optimized out>,
> > orc=orc@entry=true) at check.c:1971 #3  0x000055555555811f in cmd_orc
> > (argc=<optimized out>, argv=0x7fffffffd8d8) at builtin-orc.c:54
> > #4  0x000055555555f490 in handle_internal_command (argv=0x7fffffffd8d0,
> > argc=4) at objtool.c:108
> > #5  main (argc=4, argv=0x7fffffffd8d0) at objtool.c:131
> > (gdb) p rela->sym
> > $1 = (struct symbol *) 0x0
> 

> I'm unable to recreate.  Can you attach one of the .o files (like the
> above irq.o)?
Sure, see attached. (From vanilla linux-4.14.11.)

BR,
Markus
--nextPart2431370.87AU1eJE5D
Content-Disposition: attachment; filename="irq.o.xz"
Content-Transfer-Encoding: base64
Content-Type: application/x-xz; name="irq.o.xz"

/Td6WFoAAATm1rRGAgAhARwAAAAQz1jM4EJ3DPpdAD+RRYRoPYmm2pymrC4ry8njaQReW8VDIyYg
UCHXyDsEhTsZ22BvxgPbKwNa08cGYb5vpVXxKiT2hgVfK0l2IW3ct9VBTgDA6qT8LX8m6YQWXeTg
23F9mK/ZUu7TIsL/YUyRU2Hb1i4dUYqAsPIlg//7T2SQu8Ic821tBKyXWVyHMenhHpl+isn1xZAx
3VVPSyDuwp9LvUiCHNi/NSO5nYYJW8Z1X4wA7vnrFKeOf4fqwOLRENace/c/MK803aJZfPiHNXW1
+ZUIq2Y9L6pHLyiR6OW8c2bvoaCMmwNBzcgWbojwIOFYW5NhY8BZHtBeAmyDH1gIPLUdfPWhQ0Io
OmNJOwCWlMDt9Yu3JL7OmnMS9qYcmz4VYLkv2l5m/qVE52Rjq7bQoSS6EAwsknr2gNXTm0TIioBM
l+1fn8GC9mgdUmQ9pqHGbUbelY9YHSx7S86KiWHnVPwOd2BXG4SwE12zVop2jZXPzHYkfBtSSC80
zWLW+AXuszMmIHqye9kRIhbNygLSiXYEKA2S9fdl9Ili8mJhJA/hho1sJ7MOnysvA8Roci1Uql0B
87+kMrALs7CfNGv20Md6HMTVNu/idxu6zFPdMxoAKslVMhbvKe7CD/Jyib2ZBWjrgqZY3yB2j9qH
vpDt7Q7vMIWFMQcuPKOjXHGMUxaKhCakS0YZLuGMrD6D8lV6neo4sZcyY/vo++3dKUaKTO7N8cuM
GPC+68GP63dwe8v2CG7D4VWkW7OqwL4cP1mMeMmx4DAoCG9DM6oLScv065upFqBKaVvC/dZAIHi1
yLGrz3vE7BOM31MugJuNf3wcivYVRU7isXZjbrteepa332q7PArsumgjzShLK1wyn8GUA3MkATXp
piG1VBbpTn6533fVtKowo8fOedTaDKI45u1V8JIMrd2K17I5KojFqFWaj+6Cdc2HvPA9j7eFZJHm
wOzpDfoAfbEdcIqQwAKVp75bCExdJHVQzYHUJdySB7YL7YfQdb3Td2Mp4kMVtUyRUOK6UizV/tdu
tZpojlivnAKWTHss7vL0G3NKA+pJbo7z8o0VfwMXJMQz0DKWwKH7vI7RNsbE98vNVsTG6KE7wIxG
q+LnDpshCngq9CkrxjgqVGoasKl6nDNf06TtFZLprL2RRYpa2iN0okjQPllz4BzgfDSKKFfNfYh3
g3k2rVoTMbq18oQWyqsUY7+M531oHZuWj9AIWmccbH407uvIl+RH4+NK/luL32E1do1WUxOgG7DV
NpGejOe8EhpjOLq9mCWY0NnILVmjcVSt4iZyhMx+tSiL2P2c2/XDKPnfh3vQqXZsYttQm401xNrT
ewO4e+pPxB0kCntKlk0nKJV+deIJB6P5kD0SEiGUCctWA4xo1uoWwTaxGTZBKA/fwOxRoyqp3dMt
gD8OPpFg5Czwtsm8MOfvcah7mV+HPbRSCwwyMPkskF//rtNbB+5SPxpuwK6nYEmN5ipME3owi3oK
vRWgQ+TkXXJ5z/lEMe8jyq7oTF+i7S/zjDPkWGN404T0rfowl3COm3L2gL4SrMSmtrwbDtCGzm36
dgid9GzrhDF6E7T5BqPUqCI8rxYxcB+V8sKZesiPzWviVd8L9wXffLFhW5NThVFzSZYCHlxYfnZL
a/+j7lCm6UR5PhrbPjCwNc4xURJZQBesitpm1K/col/FeaPDtnsJ00aKtdHIAXUh/5761PVkDdtR
tM8j1A6HhcjQx/kd/NYIQnFOQGEy3SbkAjm1qNPE+kTtsI5uhq+ZFNc3cUq3KGeIY5Vwq/6d9+PL
G21aSPETSV2H2l0Qv4XlBI/d8dJOWFM206wOqjZWuflQvQNvms7gP2R/oDQbTRREoAQiZ0Yik8+g
y/kA9qU1NXXCfPVXPt2N3Fs3xP9OHbh50qOXfAni1Fmnsj5UIsho6spGeSDgtC9hhKS1FLRtTDdo
KNQgn8OQ+D/U9LqaUOHhdoCH+hJp6jgtV662qGc5KnHlSNlyJCBSad2BuTb6x41VkdAiuv6N2kBR
JwW0cFiH5A7fVV89RtwemzuY5gsGUqI/uNob1m2qzdBhyM78ZcvqKf3ku0gBOHXcpUpYkeP0leTm
BK43je162yn4KF6jMHrS6B3BYcCijjq+XniG2PuvDAJmZ/oBh11UoqLF2oLR43EqZ7MPw5KEtF0T
RLjxW2cDb3zp1+Y50ewOXaxmKecAMBN8Us4HFSc599/thHdBCV5BQC7FQGDi4FSo9OuRHojerhXo
2I+pPLQEJo+dtGxY1taZrtMHMNbzB4qm6O8U8yhMkxPFOqdoQcLU54J3WrKaNJaeBcj36FI2+NKo
SZYe5e8uzN1yW2X97d1W4vydBIkZiInK2rzrPcZiqG9RPeQMzAUHIfy2j1+rKecqcwLwDUph6AL6
sLgxpc8Dgkt47Y6AygvcYQvxXWmmbt1Rx2d+T2sxVX6bKoELZEMpgQwwcRJGfX0yUM2R3hwn3UBf
60ekHptbbi/Q/9ZrsOpCEEqCXuZK7J8oxESDnnhgobyEnEXYj62vLuZAwQIJyQ7rFoDSh3MrzxG1
5/FHPGWHXLDz42BenSnd2LkXWLRAJwFrFYwCmd8feb2wcGMSlOh2SrHUX8kunYPIMI9T7AUN0ZGL
FP4AlvfhbQtFZgsGwF1vX1vTwICiAi8jQpjJA7If3MVLSQpesjHcA2JXe/BAP9ki3UejAyXhAXbO
57sGgX58lctXPH443fWC9d/hs92Xfd8asIXdKknhEcxqPADuXN3LVvWehrDZRm66bKG9yuvJ2v3m
Wq6hznruXywiH7vmbro6s/nvQBjD4x3kXAG3VAC/oY0ePCA7hNrNxLwRTLoDv6h/4zEvTgmS1Ios
Mugq7fnu8cnoCX/a94NaJ+cJTcFU2S6tavyVhqDSfg2dKkSmB3lVDLVkD33RHbx5GKXbNO7c1aFj
RjthTMlzT7oQnfX32amGe0E6qXC9+s1otAFZ4FrSRE1IING+BUlcbnbu3SrtTygW5VRT3uStFaLu
Mg/mT2vd4PGOHf6lE8FObLli907XH0U1bKBHY4baDfkSsdPqY0HrMEFY463Rh7N9oGgQboOIHE1C
p2ftMJzlZszLSt6db9vVN6J4Way82daCh7SzkDa/RShCJEmmslKrVnqX8vwBijAYjttXB1pPJuks
+gEBH2ahKO0Z3Nb9vph0m8I7topNAZTSGHp1QlVdlyI4lHci5JA/sYw2ZEJkb4VKsMl4JVOfGHwH
lRp6bW7SJiEqd4ySEhP5oK1CeD2kd/NfTkYLYSO9vVuIl6Acd3Wus8ktyhcNON+taZ28JGVf8tbi
i6uYY7rMFyR8oy1++YXKbipKPujy8V3Uy+CCFZ17I2aet+LoLjHGa1iw7exPrJHBxaFj2uN4Zh5T
W5y71krQOGtT3lRxjAZpYR66QbGBTVGEN5yBmeATzLnDWVcNtw2IO57BewB4D1bBNcSaOCxYh209
SDgfuLO61omXPhQ8nFyvo0m+GD6xMEPwcHD8bjQjWjGdqDDqTPzjOSzbnWdEtaZ650KpwV04buM/
sbnLnezZ7n3COy4Dc8VEpeCQfhOs0EfsFf+wXRU3VuqbolKqnbTdlMcGhGT4pgmf3xXpMwVn67XO
/DB7m/brCrtEhvAgG9uNjLaExbcUR9X1gaceBRUeh1nSTWlX9lRH6AA5GRfO1yLUbZZ67+6tBrwB
+G0PvS9vUwRapN8/EIzNtgq9sp0HafxG/GNYURZvUPkvzlYCeLR/3h6J4m10JqiooPnEB/0NT9ms
mGmBHeJKDaNTkJpFKyhLsb5MEIWAjMQBNgQhfroIYF/183KJCeILpoBRn+a8ca+WiikicJQRBBjT
eG5TzVAMKJwPWKu6vgrCs6789khGoxnY0GsZjCM/tIXIoFcDQjzrp3z/Gv3jXsTGos4i9Y5rBy1L
oU1rmhMFzNYniy0o1QIwUUyJS4QJyCp9Y0AZuTL4WI7UFfsnIsXu1fe/eei7ywBJgIgHCcWWVjnn
CYwpgHerMMVMoJSwtapljohxeTBJqooSlmpEukap/2DiWKT2rTCxn5fjDYunjSrBTJF9Z6TpuWwC
1+u0csdnX2u6Z5heiRwHkD53WRrL9GE7IMhNOshKD8ymOWlcE1+ZyKcXraNJeBgVPYNS0yFUThhJ
m5s8JqKqaMLmWVDn6rqcv0MGzRMSrAZduWa9rIqdL8gJPJNEyEcv2QC1NhJDF+fKReYGfmSDxoYu
W6r2NfYUtJb57tBbyoC4Tb8UudDFqha6sSmhZ+HpgjhjbudjGxVw+orAOiNIgPvET1BZ48ehazMr
imXdEIodlqllpRajgGE/ZF6wHdco9WsrLKupOlCO5gfMEawA6HnYaZJDZkeILSZH4pCoAelaQEPz
3Y86svRuZMDIqB/XspVn1vcvC96PEqCVOJm4663GAo43SMud0Cu0NYf710u7lYEAAABT9d5R+lFC
MwABlhr4hAEA9RLPnrHEZ/sCAAAAAARZWg==


--nextPart2431370.87AU1eJE5D--