Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752137AbeACOfo (ORCPT + 1 other); Wed, 3 Jan 2018 09:35:44 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:36475 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751189AbeACOfn (ORCPT ); Wed, 3 Jan 2018 09:35:43 -0500 Date: Wed, 3 Jan 2018 15:35:41 +0100 From: Antoine Tenart To: Florian Fainelli Cc: Antoine Tenart , Andrew Lunn , thomas.petazzoni@free-electrons.com, ymarkman@marvell.com, jason@lakedaemon.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux@armlinux.org.uk, kishon@ti.com, nadavh@marvell.com, miquel.raynal@free-electrons.com, gregory.clement@free-electrons.com, stefanc@marvell.com, mw@semihalf.com, davem@davemloft.net, linux-arm-kernel@lists.infradead.org, sebastian.hesselbarth@gmail.com Subject: Re: [PATCH net-next 1/6] phy: add 2.5G SGMII mode to the phy_mode enum Message-ID: <20180103143541.GE21727@kwain> References: <20171227221446.18459-1-antoine.tenart@free-electrons.com> <20171227221446.18459-2-antoine.tenart@free-electrons.com> <20171228072053.GA27336@lunn.ch> <20171228100656.GF2626@kwain> <91838ce5-a1a8-c41a-36e8-bef7adaf82fd@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <91838ce5-a1a8-c41a-36e8-bef7adaf82fd@gmail.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hi Florian, On Thu, Dec 28, 2017 at 06:16:51AM -0800, Florian Fainelli wrote: > On 12/28/2017 02:06 AM, Antoine Tenart wrote: > > On Thu, Dec 28, 2017 at 08:20:53AM +0100, Andrew Lunn wrote: > >> On Wed, Dec 27, 2017 at 11:14:41PM +0100, Antoine Tenart wrote: > >>> This patch adds one more generic PHY mode to the phy_mode enum, to allow > >>> configuring generic PHYs to the 2.5G SGMII mode by using the set_mode > >>> callback. > >>> > >>> Signed-off-by: Antoine Tenart > >>> --- > >>> include/linux/phy/phy.h | 1 + > >>> 1 file changed, 1 insertion(+) > >>> > >>> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h > >>> index 4f8423a948d5..70459a28f3a1 100644 > >>> --- a/include/linux/phy/phy.h > >>> +++ b/include/linux/phy/phy.h > >>> @@ -28,6 +28,7 @@ enum phy_mode { > >>> PHY_MODE_USB_DEVICE, > >>> PHY_MODE_USB_OTG, > >>> PHY_MODE_SGMII, > >>> + PHY_MODE_SGMII_2_5G, > >>> PHY_MODE_10GKR, > >>> PHY_MODE_UFS_HS_A, > >>> PHY_MODE_UFS_HS_B, > >> > >> There was a discussion maybe last month about adding 2.5G SGMII. I > >> would prefer 2500SGMII. Putting the number first makes it uniform with > >> the other defines, 1000BASEX, 25000BASEX, 10GKR. > > > > Good to know. I wasn't completely sure how to name this mode properly, > > but I'm fine with PHY_MODE_2500SGMII. I'll update the patches and send a > > v2 (without the dt part). > > And since you are respinning, please make sure you update phy_modes() in > the same header file as well as > Documentation/devicetree/bindings/net/ethernet.txt with the newly added > PHY interface mode. Actually it's a generic PHY mode I'm adding, not a network PHY mode. There's no phy_modes() function for generic PHYs (and this 2500BaseX mode already is supported in the network PHY modes). Thanks! Antoine -- Antoine T?nart, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com