Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753161AbeACOiK (ORCPT + 1 other); Wed, 3 Jan 2018 09:38:10 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:39527 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751596AbeACOiH (ORCPT ); Wed, 3 Jan 2018 09:38:07 -0500 X-Google-Smtp-Source: ACJfBos4uJcib09Bw4gRpa9XSSs2Zs9/yxZn2KoiIMhLhHvHAKjJY3e4XGR9i+NGlnOls6yGKE4DWw== Date: Wed, 3 Jan 2018 23:38:03 +0900 From: Stafford Horne To: Greentime Hu Cc: greentime@andestech.com, linux-kernel@vger.kernel.org, arnd@arndb.de, linux-arch@vger.kernel.org, tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, robh+dt@kernel.org, netdev@vger.kernel.org, deanbo422@gmail.com, devicetree@vger.kernel.org, viro@zeniv.linux.org.uk, dhowells@redhat.com, will.deacon@arm.com, daniel.lezcano@linaro.org, linux-serial@vger.kernel.org, geert.uytterhoeven@gmail.com, linus.walleij@linaro.org, mark.rutland@arm.com, greg@kroah.com, ren_guo@c-sky.com, rdunlap@infradead.org, davem@davemloft.net, jonas@southpole.se, stefan.kristiansson@saunalahti.fi Subject: Re: [PATCH v5 02/39] openrisc: add ioremap_nocache declaration before include asm-generic/io.h and sync ioremap prototype with it. Message-ID: <20180103143803.GI32243@lianli.shorne-pla.net> References: <3e5ba33674a883b56e20b35ea9ae34990ea838c8.1514874857.git.green.hu@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3e5ba33674a883b56e20b35ea9ae34990ea838c8.1514874857.git.green.hu@gmail.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hello, On Tue, Jan 02, 2018 at 04:24:34PM +0800, Greentime Hu wrote: > From: Greentime Hu > > It will be built failed if commit id: d25ea659 is selected. This patch can fix this > build error. Ideally you would mention the commit description since the id is not yet usptream. I found it here (its 1 in this series): https://github.com/andestech/linux/commit/d25ea659 asm-generic/io.h: move ioremap_nocache/ioremap_uc/ioremap_wc/ioremap_... > Signed-off-by: Greentime Hu > --- > arch/openrisc/include/asm/io.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/openrisc/include/asm/io.h b/arch/openrisc/include/asm/io.h > index 7c69139..6709b28 100644 > --- a/arch/openrisc/include/asm/io.h > +++ b/arch/openrisc/include/asm/io.h > @@ -29,13 +29,14 @@ > #define PIO_OFFSET 0 > #define PIO_MASK 0 > > +#define ioremap_nocache ioremap_nocache > #include Ideally we could move include down to the bottom of the file and not have to do the defines like like this, it seems clumsy to me. In 'cris', 'nios2' and other architectures I can see they have the generic include at the bottom of the file and not need for #define's. I tried that but I get a lot of errors. Does your patch to asm-generic/io.h cause build issues for those architectures as well? -Stafford > #include > > extern void __iomem *__ioremap(phys_addr_t offset, unsigned long size, > pgprot_t prot); > > -static inline void __iomem *ioremap(phys_addr_t offset, unsigned long size) > +static inline void __iomem *ioremap(phys_addr_t offset, size_t size) > { > return __ioremap(offset, size, PAGE_KERNEL); > } > -- > 1.7.9.5 >