Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753371AbeACPRf (ORCPT + 1 other); Wed, 3 Jan 2018 10:17:35 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:45719 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751909AbeACPRd (ORCPT ); Wed, 3 Jan 2018 10:17:33 -0500 Subject: Re: [PATCH v6 3/6] can: m_can: Add PM Runtime To: Faiz Abbas , wg@grandegger.com, robh+dt@kernel.org, mark.rutland@arm.com Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, nsekhar@ti.com, fcooper@ti.com, robh@kernel.org, Wenyou.Yang@microchip.com, sergei.shtylyov@cogentembedded.com References: <1513949488-13026-1-git-send-email-faiz_abbas@ti.com> <1513949488-13026-4-git-send-email-faiz_abbas@ti.com> <1308ee81-a1e9-ac5a-2d97-334fa825ef8d@ti.com> <7d857263-14a7-6001-8f13-42d80f757573@pengutronix.de> From: Marc Kleine-Budde Message-ID: Date: Wed, 3 Jan 2018 16:17:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9FJOum8Jyl85Fy0rMiJUXXBzYfzgVsd71" X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9FJOum8Jyl85Fy0rMiJUXXBzYfzgVsd71 Content-Type: multipart/mixed; boundary="3iAJdZFUjdHIwpI3NZezNil3cOLlN3ZIZ"; protected-headers="v1" From: Marc Kleine-Budde To: Faiz Abbas , wg@grandegger.com, robh+dt@kernel.org, mark.rutland@arm.com Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, nsekhar@ti.com, fcooper@ti.com, robh@kernel.org, Wenyou.Yang@microchip.com, sergei.shtylyov@cogentembedded.com Message-ID: Subject: Re: [PATCH v6 3/6] can: m_can: Add PM Runtime References: <1513949488-13026-1-git-send-email-faiz_abbas@ti.com> <1513949488-13026-4-git-send-email-faiz_abbas@ti.com> <1308ee81-a1e9-ac5a-2d97-334fa825ef8d@ti.com> <7d857263-14a7-6001-8f13-42d80f757573@pengutronix.de> In-Reply-To: --3iAJdZFUjdHIwpI3NZezNil3cOLlN3ZIZ Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: quoted-printable On 01/03/2018 04:06 PM, Faiz Abbas wrote: > Hi, >=20 > On Wednesday 03 January 2018 07:55 PM, Marc Kleine-Budde wrote: >> On 01/03/2018 01:39 PM, Faiz Abbas wrote: >>> On Tuesday 02 January 2018 09:37 PM, Marc Kleine-Budde wrote: >>>> On 12/22/2017 02:31 PM, Faiz Abbas wrote: >>>>> From: Franklin S Cooper Jr >>>>> >>>>> Add support for PM Runtime which is the new way to handle managing = clocks. >>>>> However, to avoid breaking SoCs not using PM_RUNTIME leave the old = clk >>>>> management approach in place. >>>> >>>> There is no PM_RUNTIME anymore since 464ed18ebdb6 ("PM: Eliminate >>>> CONFIG_PM_RUNTIME") >>> >>> Ok. Will change the commit message. >>> >>>> >>>> Have a look at the discussion: https://patchwork.kernel.org/patch/94= 36507/ : >>>> >>>>>> Well, I admit it would be nicer if drivers didn't have to worry ab= out=20 >>>>>> whether or not CONFIG_PM was enabled. A slightly cleaner approach= =20 >>>>>> from the one outlined above would have the probe routine do this: >>>>>> >>>>>> my_power_up(dev); >>>>>> pm_runtime_set_active(dev); >>>>>> pm_runtime_get_noresume(dev); >>>>>> pm_runtime_enable(dev); >>> >>> This discussion seems to be about cases in which CONFIG_PM is not >>> enabled. CONFIG_PM is always selected in the case of omap devices. >> >> Yes, but in the commit message you state that you need to support >> systems that don't have PM_RUNTIME enabled. The only mainline SoCs I s= ee >> is "arch/arm/boot/dts/sama5d2.dtsi" so far. Please check if they selec= t >> CONFIG_PM, then we can make the driver much simpler. >=20 > Actually the old clock management (for hclk which is the interface > clock) is still required as mentioned in the cover letter. Will change > the rather misleading description. Ok. So you can use the code as discussed on https://patchwork.kernel.org/patch/9436507/ ? Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --3iAJdZFUjdHIwpI3NZezNil3cOLlN3ZIZ-- --9FJOum8Jyl85Fy0rMiJUXXBzYfzgVsd71 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEE4bay/IylYqM/npjQHv7KIOw4HPYFAlpM8/YACgkQHv7KIOw4 HPZJvQf9F3NXfALMRuFE6FnQB0uB0VvZvdDR8UgGG8gwKN0BZuaEp1lwp+KrLEUB xdfzMoVzc2QrGtGm1DvdbvDtmOeW4PyN3eSMowBhNUqmfd3RchX9gPSFmEIk6Qxm RqakGfwsnyRYcO4IkFvohPq51OVVPzKYIIKxjQ+zqJ7/0mP9U6fjIPX3DYMYR4cY a3vB7YEx7Vr+FUqDWJ5IATAaUe5/y0rK6ea9rslSROZpq5fPT4kwQh+3COfVo55m /xtweZfEzBOtjXQZzLCkycT1l3XDO3pYMr6fdO+XO1UeByhBsW5QuT2HhURpNn8+ MabHGGAq/i5rNOAp1/ki3g3h6v/PrQ== =UCiv -----END PGP SIGNATURE----- --9FJOum8Jyl85Fy0rMiJUXXBzYfzgVsd71--