Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753432AbeACPUp (ORCPT + 1 other); Wed, 3 Jan 2018 10:20:45 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:52676 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752874AbeACPUn (ORCPT ); Wed, 3 Jan 2018 10:20:43 -0500 Date: Wed, 3 Jan 2018 16:20:36 +0100 From: Andrew Lunn To: Antoine Tenart Cc: davem@davemloft.net, kishon@ti.com, gregory.clement@free-electrons.com, linux@armlinux.org.uk, mw@semihalf.com, stefanc@marvell.com, ymarkman@marvell.com, thomas.petazzoni@free-electrons.com, miquel.raynal@free-electrons.com, nadavh@marvell.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 4/4] net: mvpp2: 2500baseX support Message-ID: <20180103152036.GC3401@lunn.ch> References: <20180103150750.12974-1-antoine.tenart@free-electrons.com> <20180103150750.12974-5-antoine.tenart@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180103150750.12974-5-antoine.tenart@free-electrons.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: > @@ -4612,6 +4616,9 @@ static int mvpp22_comphy_init(struct mvpp2_port *port) > case PHY_INTERFACE_MODE_1000BASEX: > mode = PHY_MODE_SGMII; > break; > + case PHY_INTERFACE_MODE_2500BASEX: > + mode = PHY_MODE_2500SGMII; > + break; I think this is the source of confusion with linux/phy.h and linux/phy/phy.h. What would PHY_INTERFACE_MODE_2500SGMII use? Where is this all getting confused? Should the caller to mvpp22_comphy_init() actually be passing PHY_INTERFACE_MODE_2500SGMII? What is the MAC actually doing at this point? 2500BASEX or 2500SGMII? At minimum there needs to be a comment that this is not a typ0, otherwise you are going to get patches submitted to 'fix' this. Thanks Andrew