Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751699AbeACQ1o (ORCPT + 1 other); Wed, 3 Jan 2018 11:27:44 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:44298 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751484AbeACQ1g (ORCPT ); Wed, 3 Jan 2018 11:27:36 -0500 X-Google-Smtp-Source: ACJfBotyDdqPhilr3bkXDFES9oQN9iTaNjMk5JGXE+YQlOOeQoOlwcEsUC+VRXfeQqO1DN033F0wRw== Subject: Re: [RESEND PATCH v2 15/15] arm64: dts: msm8996: db820c: Add sound card support To: Bjorn Andersson Cc: Andy Gross , Mark Brown , linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, David Brown , Rob Herring , Mark Rutland , Liam Girdwood , Patrick Lai , Banajit Goswami , Jaroslav Kysela , Takashi Iwai , linux-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sboyd@codeaurora.org References: <20171214173402.19074-1-srinivas.kandagatla@linaro.org> <20171214173402.19074-16-srinivas.kandagatla@linaro.org> <20180103002229.GV478@tuxbook> From: Srinivas Kandagatla Message-ID: Date: Wed, 3 Jan 2018 16:27:32 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20180103002229.GV478@tuxbook> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Thanks for the comments, On 03/01/18 00:22, Bjorn Andersson wrote: > On Thu 14 Dec 09:34 PST 2017, srinivas.kandagatla@linaro.org wrote: > >> From: Srinivas Kandagatla >> >> This patch adds hdmi sound card support to db820c via qdsp. >> >> Signed-off-by: Srinivas Kandagatla >> --- >> arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 5 +++++ >> arch/arm64/boot/dts/qcom/msm8996.dtsi | 33 ++++++++++++++++++++++++++++ >> 2 files changed, 38 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi b/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi >> index 9769053957af..b955769b100d 100644 >> --- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi >> +++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi >> @@ -190,6 +190,11 @@ >> }; >> }; >> >> + snd { >> + compatible = "qcom,apq8096-sndcard"; >> + qcom,model = "DB820c"; >> + iommus = <&lpass_q6_smmu 1>; >> + }; >> >> gpio_keys { >> compatible = "gpio-keys"; >> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi >> index a144cec7bb71..25c43fb8ab49 100644 >> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi >> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi >> @@ -1262,6 +1262,7 @@ >> >> phys = <&hdmi_phy>; >> phy-names = "hdmi_phy"; >> + #sound-dai-cells = <0>; >> >> ports { >> #address-cells = <1>; >> @@ -1297,6 +1298,33 @@ >> "ref_clk"; >> }; >> }; >> + >> + lpass_q6_smmu: arm,smmu-lpass_q6@1600000 { > > name this node "iommu" will rename it to arm,smmu@1600000 > >> + compatible = "qcom,msm8996-smmu-v2"; >> + reg = <0x1600000 0x20000>; >> + #iommu-cells = <1>; >> + power-domains = <&gcc HLOS1_VOTE_LPASS_CORE_GDSC>; > > Indentation sure. > >> + >> + #global-interrupts = <1>; >> + interrupts = , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + ; >> + >> + clocks = <&gcc GCC_HLOS1_VOTE_LPASS_CORE_SMMU_CLK>, >> + <&gcc GCC_HLOS1_VOTE_LPASS_ADSP_SMMU_CLK>; >> + clock-names = "iface", "bus"; >> + status = "okay"; >> + }; >> }; >> >> adsp-pil { >> @@ -1325,6 +1353,11 @@ >> qcom,ipc = <&apcs 16 8>; >> qcom,smd-edge = <1>; >> qcom,remote-pid = <2>; >> + >> + apr { > > "apr-audio-svc", as this is not the only apr channel on this edge. yep. > >> + compatible = "qcom,apr-msm8996"; >> + qcom,smd-channels = "apr_audio_svc"; >> + }; >> }; > > Regards, > Bjorn >