Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751191AbeACRBf (ORCPT + 1 other); Wed, 3 Jan 2018 12:01:35 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:53162 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750864AbeACRBc (ORCPT ); Wed, 3 Jan 2018 12:01:32 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A581C60555 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Wed, 3 Jan 2018 09:01:30 -0800 From: Stephen Boyd To: Chen-Yu Tsai Cc: Michael Turquette , linux-kernel , linux-clk , "open list:GENERIC INCLUDE/A..." , Maxime Ripard Subject: Re: [PATCH 4/5] clk: sunxi: Use CLK_IS_CRITICAL flag for critical clks Message-ID: <20180103170130.GW7997@codeaurora.org> References: <20180103013516.18844-1-sboyd@codeaurora.org> <20180103013516.18844-5-sboyd@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/03, Chen-Yu Tsai wrote: > On Wed, Jan 3, 2018 at 9:35 AM, Stephen Boyd wrote: > > We'd like to privatize __clk_get(), but the sunxi clk driver is > > calling this function to keep a reference held on the clk and > > call clk_prepare_enable() on it. We support this design in the > > clk core now with the CLK_IS_CRITICAL flag, so let's just use > > that instead. > > > > Cc: Maxime Ripard > > Cc: Chen-Yu Tsai > > Signed-off-by: Stephen Boyd > > --- > > drivers/clk/sunxi/clk-factors.c | 26 +++++++++++++++++++++----- > > drivers/clk/sunxi/clk-factors.h | 4 ++++ > > drivers/clk/sunxi/clk-mod0.c | 9 ++------- > > drivers/clk/sunxi/clk-sun8i-mbus.c | 7 ++----- > > drivers/clk/sunxi/clk-sun9i-core.c | 9 ++------- > > drivers/clk/sunxi/clk-sunxi.c | 36 +++++++++++++----------------------- > > 6 files changed, 44 insertions(+), 47 deletions(-) > > > > diff --git a/drivers/clk/sunxi/clk-factors.c b/drivers/clk/sunxi/clk-factors.c > > index 856fef65433b..f6f4757d2dd1 100644 > > --- a/drivers/clk/sunxi/clk-factors.c > > +++ b/drivers/clk/sunxi/clk-factors.c > > @@ -176,10 +176,10 @@ static const struct clk_ops clk_factors_ops = { > > .set_rate = clk_factors_set_rate, > > }; > > > > -struct clk *sunxi_factors_register(struct device_node *node, > > - const struct factors_data *data, > > - spinlock_t *lock, > > - void __iomem *reg) > > +struct clk *__sunxi_factors_register(struct device_node *node, > > This looks like it's only used within the file by the two wrapper > functions. Mark it static? Ah thanks. I hadn't run sparse yet. > > Otherwise > > Reviewed-by: Chen-Yu Tsai > > Looks like you picked the easiest (least code changes) for each type > of clock? Yep. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project