Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751215AbeACRaQ (ORCPT + 1 other); Wed, 3 Jan 2018 12:30:16 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:45840 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751053AbeACRaN (ORCPT ); Wed, 3 Jan 2018 12:30:13 -0500 Date: Wed, 3 Jan 2018 17:29:48 +0000 From: Russell King - ARM Linux To: Andrew Lunn Cc: Antoine Tenart , Florian Fainelli , thomas.petazzoni@free-electrons.com, ymarkman@marvell.com, jason@lakedaemon.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kishon@ti.com, nadavh@marvell.com, miquel.raynal@free-electrons.com, gregory.clement@free-electrons.com, stefanc@marvell.com, mw@semihalf.com, davem@davemloft.net, linux-arm-kernel@lists.infradead.org, sebastian.hesselbarth@gmail.com Subject: Re: [PATCH net-next 1/6] phy: add 2.5G SGMII mode to the phy_mode enum Message-ID: <20180103172948.GG28752@n2100.armlinux.org.uk> References: <20171227221446.18459-1-antoine.tenart@free-electrons.com> <20171227221446.18459-2-antoine.tenart@free-electrons.com> <20171228072053.GA27336@lunn.ch> <20171228100656.GF2626@kwain> <91838ce5-a1a8-c41a-36e8-bef7adaf82fd@gmail.com> <20180103143541.GE21727@kwain> <20180103150830.GB3401@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180103150830.GB3401@lunn.ch> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, Jan 03, 2018 at 04:08:30PM +0100, Andrew Lunn wrote: > > > >>> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h > > > >>> index 4f8423a948d5..70459a28f3a1 100644 > > > >>> --- a/include/linux/phy/phy.h > > > >>> +++ b/include/linux/phy/phy.h > > > >>> @@ -28,6 +28,7 @@ enum phy_mode { > > > >>> PHY_MODE_USB_DEVICE, > > > >>> PHY_MODE_USB_OTG, > > > >>> PHY_MODE_SGMII, > > > >>> + PHY_MODE_SGMII_2_5G, > > > >>> PHY_MODE_10GKR, > > > >>> PHY_MODE_UFS_HS_A, > > > >>> PHY_MODE_UFS_HS_B, > > > >> > > > >> There was a discussion maybe last month about adding 2.5G SGMII. I > > > >> would prefer 2500SGMII. Putting the number first makes it uniform with > > > >> the other defines, 1000BASEX, 25000BASEX, 10GKR. > > > > > > > > Good to know. I wasn't completely sure how to name this mode properly, > > > > but I'm fine with PHY_MODE_2500SGMII. I'll update the patches and send a > > > > v2 (without the dt part). > > > > > > And since you are respinning, please make sure you update phy_modes() in > > > the same header file as well as > > > Documentation/devicetree/bindings/net/ethernet.txt with the newly added > > > PHY interface mode. > > > > Actually it's a generic PHY mode I'm adding, not a network PHY mode. > > There's no phy_modes() function for generic PHYs (and this 2500BaseX > > mode already is supported in the network PHY modes). > > Hi Antoine > > Don't you need it in both include/linux/phy/phy.h and > include/linux/phy.h? Is it really 2.5G SGMII or 2.5G Base-X - iow, which configuration word is permissible at 2.5G speeds for the pp2? We already have 2500BASEX in linux/phy.h, which is the 802.3z compliant 16-bit configuration word rather than the Cisco variant. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up