Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751278AbeACShQ (ORCPT + 1 other); Wed, 3 Jan 2018 13:37:16 -0500 Received: from mail-bl2nam02on0106.outbound.protection.outlook.com ([104.47.38.106]:50688 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751191AbeACShO (ORCPT ); Wed, 3 Jan 2018 13:37:14 -0500 From: Ryan Lee To: Rob Herring CC: "lgirdwood@gmail.com" , "broonie@kernel.org" , "mark.rutland@arm.com" , "perex@perex.cz" , "tiwai@suse.com" , "arnd@arndb.de" , "afd@ti.com" , "robert.jarzmik@free.fr" , "supercraig0719@gmail.com" , "jbrunet@baylibre.com" , "dannenberg@ti.com" , "romain.perier@collabora.com" , "bryce.ferguson@rockwellcollins.com" , "kuninori.morimoto.gx@renesas.com" , "m-stecklein@ti.com" , "alsa-devel@alsa-project.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "ryan.lee.maxim@gmail.com" Subject: RE: [v2] ASoC: max98373: Added Amplifier Driver Thread-Topic: [v2] ASoC: max98373: Added Amplifier Driver Thread-Index: AQHTfZKAmlYVZP3DfECk8FRw5GhCG6NWSJ6AgAw/R4A= Date: Wed, 3 Jan 2018 18:37:09 +0000 Message-ID: References: <1514214610-17630-1-git-send-email-ryans.lee@maximintegrated.com> <20171226233307.hdjxi5ntt7c5i2v4@rob-hp-laptop> In-Reply-To: <20171226233307.hdjxi5ntt7c5i2v4@rob-hp-laptop> Accept-Language: en-US, ko-KR Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=RyanS.Lee@maximintegrated.com; x-originating-ip: [204.17.143.20] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BY2PR11MB0838;7:8SmsQV9McoI0ySkHfxNbftM4onWOWyGgHFLtu1L7AcdbmC3unHoxDguCXGUBaUa4u/ZATUSpDhBjndoPv9U7HbKe8kZRNUEgN6vL2cTMuUtVHx23x3nRBTB6/xVv1Ptu2AqZoVYfxeF8/nLsZS5JrBsiNGfB2tDFw5QOe3+ShadE7ZixHjv37P8FNx0S3yxMYNLelhXOJkutuDEnZwRok7VIPJwjPpkryHzOOJ2ju9lItIOzOr6Y26Uv1lva5pAH x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: fbf42267-bee5-48e5-d7dd-08d552d8ff91 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(48565401081)(2017052603307)(7153060);SRVR:BY2PR11MB0838; x-ms-traffictypediagnostic: BY2PR11MB0838: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(191636701735510)(180628864354917)(31051911155226)(9452136761055)(108721460000369); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(8121501046)(5005006)(3002001)(3231023)(944501075)(93006095)(93001095)(10201501046)(6055026)(6041268)(20161123560045)(20161123558120)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:BY2PR11MB0838;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:BY2PR11MB0838; x-forefront-prvs: 0541031FF6 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(376002)(346002)(39380400002)(39860400002)(396003)(189003)(199004)(24454002)(13464003)(66066001)(6116002)(97736004)(25786009)(2906002)(99286004)(229853002)(8936002)(6916009)(68736007)(2950100002)(6246003)(4326008)(5660300001)(3846002)(86362001)(2900100001)(7416002)(102836004)(39060400002)(6506007)(74316002)(7736002)(8676002)(106356001)(105586002)(345774005)(305945005)(7696005)(55016002)(14454004)(53936002)(76176011)(3660700001)(81166006)(81156014)(316002)(72206003)(3280700002)(77096006)(54906003)(33656002)(478600001)(9686003)(6436002)(15866825006);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR11MB0838;H:BY2PR11MB0837.namprd11.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; x-microsoft-antispam-message-info: K4TjDLwqGPDCNWf6E/zWE2vt2uZkqyqFk+4gRDoXaBPUzT/7skS/63CDvDPBegVmdBTIhF/2gJrjEtgIuVRhgw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: maximintegrated.com X-MS-Exchange-CrossTenant-Network-Message-Id: fbf42267-bee5-48e5-d7dd-08d552d8ff91 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jan 2018 18:37:09.4611 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fbd909df-ea69-4788-a554-f24b7854ad03 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR11MB0838 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: >-----Original Message----- >From: Rob Herring [mailto:robh@kernel.org] >Sent: Tuesday, December 26, 2017 3:33 PM >To: Ryan Lee >Cc: lgirdwood@gmail.com; broonie@kernel.org; mark.rutland@arm.com; >perex@perex.cz; tiwai@suse.com; arnd@arndb.de; afd@ti.com; >robert.jarzmik@free.fr; supercraig0719@gmail.com; jbrunet@baylibre.com; >dannenberg@ti.com; romain.perier@collabora.com; >bryce.ferguson@rockwellcollins.com; kuninori.morimoto.gx@renesas.com; m- >stecklein@ti.com; alsa-devel@alsa-project.org; devicetree@vger.kernel.org; >linux-kernel@vger.kernel.org; ryan.lee.maxim@gmail.com >Subject: Re: [v2] ASoC: max98373: Added Amplifier Driver > >EXTERNAL EMAIL > > > >On Mon, Dec 25, 2017 at 07:10:10AM -0800, Ryan Lee wrote: > >Needs a commit message. > >> Signed-off-by: Ryan Lee >> --- >> >> Changes since v1: >> * Removed 'codec' from 'max98373_priv' structure >> : Now 'max98373_set_clock' function use 'dai->codec.dev' instead of >using 'max98373->codec.dev'. >> * Removed 'max98373_dai_set_sysclk' function >> : This function is not necessary. Removed 'sysclk' from >'max98373_priv' as well. >> * Removed 'iface' from 'max98373_priv' structure >> : There is no function who refer max98373->iface variable. >> * Added SPDX-License-Identifier >> >> .../devicetree/bindings/sound/max98373.txt | 43 + > >Please split bindings to separate patch. Thank you for the feedback. I will split it. > >> sound/soc/codecs/Kconfig | 5 + >> sound/soc/codecs/Makefile | 2 + >> sound/soc/codecs/max98373.c | 974 >+++++++++++++++++++++ >> sound/soc/codecs/max98373.h | 212 +++++ >> 5 files changed, 1236 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/sound/max98373.txt >> create mode 100644 sound/soc/codecs/max98373.c create mode 100644 >> sound/soc/codecs/max98373.h >> >> diff --git a/Documentation/devicetree/bindings/sound/max98373.txt >> b/Documentation/devicetree/bindings/sound/max98373.txt >> new file mode 100644 >> index 0000000..22cd259 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/sound/max98373.txt >> @@ -0,0 +1,43 @@ >> +Maxim Integrated MAX98373 Speaker Amplifier >> + >> +This device supports I2C. >> + >> +Required properties: >> + >> + - compatible : should be one of the following >> + - "maxim,max98373" >> + >> + - reg : the I2C address of the device. >> + >> +Optional properties: >> + >> + - maxim,vmon-slot-no : slot number used to send voltage information >> + or in inteleave mode this will be used as >> + interleave slot. >> + slot range : 0 ~ 15, Default : 0 >> + >> + - maxim,imon-slot-no : slot number used to send current information >> + slot range : 0 ~ 15, Default : 0 >> + >> + - maxim,spkfb-slot-no : slot number used to send speaker feedback >information >> + slot range : 0 ~ 15, Default : 0 >> + >> + - maxim,interleave-mode : When using two MAX98373 in a system it is >> + possible to create ADC data that that will >> + overflow the frame size. Digital Audio Interleave >> + mode provides a means to output VMON and IMON data >> + from two devices on a single DOUT line when running >> + smaller frames sizes such as 32 BCLKS per LRCLK or >> + 48 BCLKS per LRCLK. >> + Range : 0 (off), 1 (on), Default : 0 > >This can be boolean instead. I will change this to boolean type. > >> + >> +Example: >> + >> +codec: max98373@31 { >> + compatible = "maxim,max98373"; >> + reg = <0x31>; >> + maxim,vmon-slot-no = <0>; >> + maxim,imon-slot-no = <1>; >> + maxim,spkfb-slot-no = <2>; >> + maxim,interleave-mode = <0>; >> +};