Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751317AbeACT2m (ORCPT + 1 other); Wed, 3 Jan 2018 14:28:42 -0500 Received: from mail-yw0-f174.google.com ([209.85.161.174]:32838 "EHLO mail-yw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750865AbeACT2k (ORCPT ); Wed, 3 Jan 2018 14:28:40 -0500 X-Google-Smtp-Source: ACJfBosRNwT+vX+TjrnqVmTUgyZxUiABabYfnzv5Arxzwcbvh2fAxkBtKAP9cTT0oJF4dQ6tGGQX+boVgmGKI8f1Nds= MIME-Version: 1.0 In-Reply-To: References: <6cdc726b-82bc-85b6-393b-0e2002c19341@users.sourceforge.net> From: =?UTF-8?B?TWFoZXNoIEJhbmRld2FyICjgpK7gpLngpYfgpLYg4KSs4KSC4KSh4KWH4KS14KS+4KSwKQ==?= Date: Wed, 3 Jan 2018 11:28:18 -0800 Message-ID: Subject: Re: bonding: Delete an error message for a failed memory allocation in bond_update_slave_arr() To: SF Markus Elfring Cc: linux-netdev , Andy Gospodarek , Jay Vosburgh , Veaceslav Falico , LKML , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, Jan 3, 2018 at 12:45 AM, SF Markus Elfring wrote: >>> Omit an extra message for a memory allocation failure in this function. >>> >>> This issue was detected by using the Coccinelle software. >>> >> What is the issue with this message? > > * Is it redundant? > > * Would a Linux allocation failure report be already sufficient here? > If you see 8 out of 9 call sites in this file ignore the return value. This message in the log could give a clue when debugging. Unless it's spamming it's not harmful, or is it? > Regards, > Markus