Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752213AbeACUN2 (ORCPT + 1 other); Wed, 3 Jan 2018 15:13:28 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:43553 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752143AbeACUNV (ORCPT ); Wed, 3 Jan 2018 15:13:21 -0500 X-Google-Smtp-Source: ACJfBou7+Gxg4q4jiNNLpfNZ1XAGU1OhFUAQw8e0JqgOM9Ay0OC0UDQorvnqEAb0VTRUPEt64u86zA== From: Corentin Labbe To: alexandre.torgue@st.com, arei.gonglei@huawei.com, corbet@lwn.net, davem@davemloft.net, herbert@gondor.apana.org.au, jasowang@redhat.com, mcoquelin.stm32@gmail.com, mst@redhat.com Cc: linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, fabien.dessenne@st.com, Corentin Labbe Subject: [PATCH 0/6] crypto: engine - Permit to enqueue all async requests Date: Wed, 3 Jan 2018 21:11:03 +0100 Message-Id: <20180103201109.16077-1-clabbe.montjoie@gmail.com> X-Mailer: git-send-email 2.13.6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hello The current crypto_engine support only ahash and ablkcipher request. My first patch which try to add skcipher was Nacked, it will add too many functions and adding other algs(aead, asymetric_key) will make the situation worst. This patchset remove all algs specific stuff and now only process generic crypto_async_request. The requests handler function pointer are now moved out of struct engine and are now stored directly in a crypto_engine_reqctx. The original proposal of Herbert [1] cannot be done completly since the crypto_engine could only dequeue crypto_async_request and it is impossible to access any request_ctx without knowing the underlying request type. So I do something near that was requested: adding crypto_engine_reqctx in TFM context. Note that the current implementation expect that crypto_engine_reqctx is the first member of the context. The first patch is a try to document the crypto engine API. The second patch convert the crypto engine with the new way, while the following patchs convert the 4 existing users of crypto_engine. Note that this split break bisection, so probably the final commit will be all merged. Appart from virtio, all 4 latest patch were compile tested only. But the crypto engine is tested with my new sun8i-ce driver. Regards [1] https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1474434.html Changes since RFC: - Added a documentation patch - Added patch for stm32-cryp - Changed parameter of all crypto_engine_op functions from crypto_async_request to void* - Reintroduced crypto_transfer_xxx_request_to_engine functions Corentin Labbe (6): Documentation: crypto: document crypto engine API crypto: engine - Permit to enqueue all async requests crypto: omap: convert to new crypto engine API crypto: virtio: convert to new crypto engine API crypto: stm32-hash: convert to the new crypto engine API crypto: stm32-cryp: convert to the new crypto engine API Documentation/crypto/crypto_engine.rst | 46 ++++++ crypto/crypto_engine.c | 230 +++++++++++++-------------- drivers/crypto/omap-aes.c | 17 +- drivers/crypto/omap-aes.h | 3 + drivers/crypto/omap-des.c | 20 ++- drivers/crypto/stm32/stm32-cryp.c | 21 ++- drivers/crypto/stm32/stm32-hash.c | 18 ++- drivers/crypto/virtio/virtio_crypto_algs.c | 10 +- drivers/crypto/virtio/virtio_crypto_common.h | 3 +- drivers/crypto/virtio/virtio_crypto_core.c | 3 - include/crypto/engine.h | 59 ++++--- 11 files changed, 263 insertions(+), 167 deletions(-) create mode 100644 Documentation/crypto/crypto_engine.rst -- 2.13.6