Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751661AbeACXK0 (ORCPT + 1 other); Wed, 3 Jan 2018 18:10:26 -0500 Received: from mga05.intel.com ([192.55.52.43]:58816 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751378AbeACXJr (ORCPT ); Wed, 3 Jan 2018 18:09:47 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,504,1508828400"; d="scan'208";a="17284144" From: Andi Kleen To: tglx@linuxtronix.de Cc: torvalds@linux-foundation.org, gregkh@linux-foundation.org, dwmw@amazon.co.uk, tim.c.chen@linux.intel.com, linux-kernel@vger.kernel.org, dave.hansen@intel.com, Andi Kleen Subject: [PATCH 11/11] retpoline/objtool: Disable some objtool warnings Date: Wed, 3 Jan 2018 15:09:34 -0800 Message-Id: <20180103230934.15788-12-andi@firstfloor.org> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180103230934.15788-1-andi@firstfloor.org> References: <20180103230934.15788-1-andi@firstfloor.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: From: Andi Kleen With the indirect call thunk enabled compiler two objtool warnings are triggered very frequently and make the build very noisy. I don't see a good way to avoid them, so just disable them for now. Signed-off-by: Andi Kleen --- tools/objtool/check.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/tools/objtool/check.c b/tools/objtool/check.c index 9b341584eb1b..435c71f944dc 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -503,8 +503,13 @@ static int add_call_destinations(struct objtool_file *file) insn->call_dest = find_symbol_by_offset(insn->sec, dest_off); if (!insn->call_dest) { +#if 0 + /* Compilers with -mindirect-branch=thunk-extern trigger + * this everywhere on x86. Disable for now. + */ WARN_FUNC("can't find call dest symbol at offset 0x%lx", insn->sec, insn->offset, dest_off); +#endif return -1; } } else if (rela->sym->type == STT_SECTION) { @@ -1716,8 +1721,14 @@ static int validate_branch(struct objtool_file *file, struct instruction *first, return 1; } else if (func && has_modified_stack_frame(&state)) { +#if 0 + /* Compilers with -mindirect-branch=thunk-extern trigger + * this everywhere on x86. Disable for now. + */ + WARN_FUNC("sibling call from callable instruction with modified stack frame", sec, insn->offset); +#endif return 1; } -- 2.14.3