Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751789AbeADBEc (ORCPT + 1 other); Wed, 3 Jan 2018 20:04:32 -0500 Received: from mail-he1eur01on0041.outbound.protection.outlook.com ([104.47.0.41]:60356 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751206AbeADBE3 (ORCPT ); Wed, 3 Jan 2018 20:04:29 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=saeedm@mellanox.com; Subject: Re: [PATCH] net/mlx5e: hide an unused variable To: Arnd Bergmann , Matan Barak , Leon Romanovsky Cc: Or Gerlitz , Hadar Hen Zion , "David S. Miller" , Paul Blakey , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180103224022.3737385-1-arnd@arndb.de> From: Saeed Mahameed Message-ID: Date: Wed, 3 Jan 2018 17:04:03 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180103224022.3737385-1-arnd@arndb.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: MWHPR22CA0023.namprd22.prod.outlook.com (2603:10b6:300:ef::33) To DB3PR05MB0859.eurprd05.prod.outlook.com (2a01:111:e400:5049::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 16ce2ba4-d18a-4c55-3fca-08d5530f1580 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7153060);SRVR:DB3PR05MB0859; X-Microsoft-Exchange-Diagnostics: 1;DB3PR05MB0859;3:6G8pQvSH5KIoTlMOiJ9Nidnrp9309YQcT93y6chNEtaK+8wAisVEv2+j/p5G1YW/Xd/JQsf9nPVRH0NrtMLJD5P9a5Uti1oPzr7bjE+6n1wNtI+PPlQalxTU46T/ctuPP/gcJq/2naYMM8WOyz6yR3RehdJjJSyxDqtihAnzSZxK/t1yOaLqTrdnnpmvOcCEQ/7hUNCawDOoHWykPcPPcBWvsMa6K1BMIrKP3T4nL0eEVPKFL94r0RLupCdgNGw6;25:Zc0+ZcfcwTfiNcPkEBk0nWv+npyjEtAOIVgWXWx48jVhB5BfRJV5QgAnn5+87V+qgTKHCHMzdsdoT8T1CelJX8CvVPPy5qNC5WVpBhlu5783tanehpZbxcv1p34p6o8I/8hbebPpjFnSPSPBpu6gF2UK+/uxe/x9vXdjR4EH/UNfbjW4lPlrhJJxOJqD3j7u32ZLnNaRCst7ph1qB9KuFbAY7IdPQzajAkCKjQFgJsbCh8iPFnny4y4D3xanbJJegCqLDAHsiD3dWJVj0hXE4+/75x5LdSY/Pu6MMe7Dh+K4+1XNsS3pA4ju/y4Gt1Vi/1FdwFnF4vgPAg6pVq134w==;31:u1F+WnttRkCq9g7/MDi1o3Low/gXeHL1jb6Ls2KaZZvnp42137xqTjx41OtDJe8USXDDo2tJacXGvnIpkf0e+Qk+o03q4sRggszheQmK3zyzuSGqmMz3igT6qYn1qT/AMbCKc8YR3INf4wM7yYsu5MavtYoB/cFQjcHQHtLfY6R+rgIpGIlM2GGkTxHBuHlJKkkQqoFzb5qCQzCB6WtweKauGChxsbNqIc+WOuTnO1g= X-MS-TrafficTypeDiagnostic: DB3PR05MB0859: X-Microsoft-Exchange-Diagnostics: 1;DB3PR05MB0859;20:22sclxBdb0WNqJzbtI3SAmcjHIBeME6mAOOUPnGTgyyG/TyIythylq7b7juknKJsdjOP7YOQTScoKKfWaaeUHErzjnOskdIh3xhitNbqXxeqqI5LRtcXGI5f3ojsN/JetFsacHeOcVEjR9IjvluIuWVCYlwZvRKAJ/ZzmmRZDuVoSt/3nz7wtEkDzQXGDCK/XCogvtrMABrjapM560Yic8L25HAywD1g+Y/9kZwyxlWmt2/U4L6YQLui5rRek3CSGtqcz8t/sLn3a5JcpqwdiASt9Lcnfnu5JA2HlqavlgP2lRU4yueqFngorHbA5xAxKDjyOWc9MMXhfG0wYgWG6GfWzwIucAwwG0ke2v6YTBbKFUI29QJt16Sa/aiWwLFWRpAWpwwWui9XiTw9perkx8HxR0l9/4cJLuPdjyQtNGO5D/IS7eoIBRi8fKeIzqK65fuuDShNYsHpzbVz0j38qrDqSy4nh0qGVoPaCOQhBktr1vCYUQC6kh1b9x+n1LYy;4:sW/bW3TKoI7Bgr7o9PVnlAB1qu9hJJnrSScNLErHpZeuCNB98q4p6G9MCMdrDqawlbS9aRfTPAyCWvvqUmDf0Wh21NDXix+tGyPWI0tYYKGi6d0vHSqPcbqVWOho0r3X+HQHbS24r9PefTtE5I7z4fR0LOxod9xWFsjZIPbhBSIWc28djYA3khw+OHF8tuWWqiEdXj7vfwywAzSoNmdE0NfV25u+pKUWf0sSIlGyw2VGp67yZXH/LAm+GvBiJqLNNzzoipMgDs/EIqI+SAXnVxr9CvDPxCFtfPF0a7LswLrVsZPhy6UhnvqtlQwrGUlv X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(17755550239193); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(8121501046)(5005006)(3002001)(3231023)(944501075)(93006095)(93001095)(10201501046)(6055026)(6041268)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:DB3PR05MB0859;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:DB3PR05MB0859; X-Forefront-PRVS: 054231DC40 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(396003)(39380400002)(346002)(376002)(366004)(39860400002)(199004)(189003)(24454002)(3846002)(64126003)(25786009)(31696002)(106356001)(83506002)(6246003)(50466002)(105586002)(3260700006)(86362001)(31686004)(230700001)(81166006)(8676002)(16526018)(81156014)(4326008)(58126008)(110136005)(68736007)(8936002)(16576012)(54906003)(6116002)(229853002)(305945005)(36756003)(6486002)(478600001)(316002)(7736002)(77096006)(53936002)(6636002)(6666003)(65826007)(97736004)(23676004)(52146003)(52116002)(53546011)(5660300001)(65806001)(66066001)(76176011)(67846002)(386003)(2486003)(65956001)(2906002)(2950100002)(47776003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB3PR05MB0859;H:[10.9.6.17];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjNQUjA1TUIwODU5OzIzOjRKU0pBOVdDOG4ySzBOY3NhaDcyNFZLZEd4?= =?utf-8?B?b1FnZ1J3Q3VxVmpma1NVMFF4MzJmUkFhZmtvNEVVTVpDMVBkbFZtWWx1Vk5a?= =?utf-8?B?T0ZtMlNsMFBnbXBIOTJiQm5KaSttR0o3UDJkQzF1c2RkRXBFZ0ZyUHMzdEVY?= =?utf-8?B?ZXdjS2E0NXZ3em8vVFNPNVBvQ2d3V1JhNXpzaDZRTjNnM3dQQWxzWXlJNkxX?= =?utf-8?B?VmFXS21CWmlNMFVFWDEwd0did2RPc1dyRFhKM3hBTUNNTENmakpnU3dwQTNi?= =?utf-8?B?Zm1yZ2xHYnNqdlA0T2tQSk5mVmRmd1NZNEdBU2UzM1A4U2lOeXdpUXBCMDFy?= =?utf-8?B?a1htY3NSUlF4alpnRlFpeFZiakJQU01paEY0dGZoSzNQelFOUktxOW83U1FS?= =?utf-8?B?VHFKU2NRZ3FYK09tMVJVeTZPbUhtdGZmUVR6RkhGcVFWWXBsK2RGMkRMN09Z?= =?utf-8?B?NS9WWGhSeERCVlJqOHRDZXFRakNYSEEwU29jRWlrUzJaL1I3a0lxazdBeDVT?= =?utf-8?B?NnFCdjREVSs3eEg4aU45a3gyTHhydzRhWkJnTzZ3VHZrRDZkVVNiZi90SEFQ?= =?utf-8?B?TTh3bWpJeXNLSEZBYy9uYzZMVVZiTjFEY2kvdm96bGR0aEFxZDkvc1J6b0F6?= =?utf-8?B?NlNtbnhkVXJYWEFvK2hpcVVKVUg3RUZqdURvdWI5MlA3WFFURlczVmpPSnJp?= =?utf-8?B?UXdBR0UyWVh2aXRhZkkvUnNCKzlIazVxTmVmcW5GUHpJbDhDM3J6QzhuTzVp?= =?utf-8?B?SHhmK0hYWmlSc1IwTzdSTmJmcmY5ZnU3eEkydTRqcUtMMWlFTDlITno4VkNr?= =?utf-8?B?OVdZUk0zM2FhUmRWNVAwczdmbEFqbmRSVlhTK3RudFlmNkJ1YmxtbGxxVTRk?= =?utf-8?B?aStPSFUwTjg5RWJRa1VlYXZoZ2UzaWRwUUQ0Qk1WYVh6Vis5bTI1MGRBbFhM?= =?utf-8?B?MVVBVE0reG90ZnhzSHV6WkI5VTU1S1ZCVG1JNkpVNkZma0FkUzUzWU1OZ0Qy?= =?utf-8?B?dzJXRk9PUjA3YmNidUhocVZiYXVrbXgvaTVhbDhkZHFJa0IzbmZmR1ptN1Qw?= =?utf-8?B?WVJWVWgrSzIwMTFiZGpnaFlPTllrQXZSazhXK1Q4NW1CQyt2Z0ZUNXE2LzBB?= =?utf-8?B?d3B1ektaSkU2cGFmRldINy9YWVdnZ1RPcGZlWUdXd1h4bDZsb3dRS2lIVzhM?= =?utf-8?B?eGJlbERWMlAvaGNWM1lnR3hPSm0wUHF0SjZCaHJobC9rb2xMb0VRMlFCb3A3?= =?utf-8?B?QXYvbi9VQXpYS0dJUlJqZ2JkWHd6R3ZibnpLYndMR3NZZXlUY3VqTDhFNFBM?= =?utf-8?B?WmI1UTBJNXJoMGxOTnBHNzlLMXdMalZ2dEJjSk9JQjNzNW5hTjFlM29Wa0J1?= =?utf-8?B?YUl6TW1TenBDTGxNRkRHalM0Nk9jK3JiMDV2NDdGVWl1cmJxNjdsUXFLUWZ2?= =?utf-8?B?ZnZUbDBsaHFIeVVmdngxMGVzaVc2Zk5qdWMzMmdaak5Rdm1MSHhyMnErYTZQ?= =?utf-8?B?Vkh0QjFsK1JvdzhNNktoTVZOUURoZUZtSHR6QzF4TlJqOUFqbmRHYU91UTVU?= =?utf-8?B?Y1BHeVBjQTlKOUNLZU42RDVhRUtaVkhRWDRaNUlDUTdhQUFDNk1PYmJyV0xZ?= =?utf-8?B?UkpzaDVSMWoyU0MxRm5YVWJEa0g3MUljV1VOV3NXWGU2dEJKc3A0R0s0R1FL?= =?utf-8?B?S1VuQmhYTGpUczY0dlJXOS81QUc1THJkMmhEQ2x6Q3pybnY5VmUwV3RwZVp4?= =?utf-8?B?bGFtRUhFc3B5cDJmQm1rTHo4cnNBWFkwdjVCd0NmMkxFblNZaEtyUENCM25q?= =?utf-8?B?OVdzSHFkUlNNNEx4Wlc0REI5Vi93eks2czZHQ1g4eHNQWi9yMkVYR3ZWOVIz?= =?utf-8?B?ZGY1VkNDOVVGN2JHWU0vVzc0cFQ1YWE2V2M3dlJ3VWU1QkZPRUMxcUxwN21G?= =?utf-8?Q?TA8iTs5DozupivCg3/l7nK7UvznYfk=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB3PR05MB0859;6:t1m0LQEsatIc3/zVVNbN0WTMaO2keeWWkqRCexKDNfzGC6Jt3aYd+BJryNHvcQ/pVQnyK+o7xyKvl649USLrSqHWyI3a5xX8sThKSc7wIM5RW0DtElTE3GjoDjKTwxrldRkpYqvvdtg+04ZeGaIJaURCVaB6vRaOOB6SmeVsdpsVrk9niisWvAJO93rbOHLy8fQ0rlR9dCSzBrX9STeeRuzXrulDfsFHb6N0FbAa2IhQkiqKPRDdbBPk8B4wA0BovPhaQ886I3BV6A30GEhyBI2zTLDeP/pfqxejPyVxloXtzGz+WkviTd2q5bCxeUN1yMRVohEw6zHK1BMdXHnlIqQLuRtNP0Qv+QWkDVuoa3E=;5:JBXaKEe2ZmVg3/HnFfl436TymfEaulassEZKJOyCq61MMKJmaZW1/oWFOT2HA0I9vflTeUP/h87Y6+IU7jhOXNG9N6jwSH3TLV+p+4z0XFDDtHM7FqeeKOa5rXPcxJl2lebWyGetQwIn7tVSprPNMZXnDzAcovsnUg9Ws96q5eE=;24:Y2ygHBnHJAK8gPYqEdh/iOXB78qv9n2vFsUhKczbmpiTb97N660FGluSW0Qa9FTuemGz42YKdSMEi9XTLD757IpK3SSlwD7DjcqCmTRfRHY=;7:hWJE3wphV+oamYtXKfq6LBgdZjQABygTcHH/UotB1h0B7dTHf1A6MgNZ+XCnUP86y2WjKG+o2u00rYEBL+j2ffoBH8GfaIxEjfXbOqEL7Kt8iLE/CkQx9vFIh7h9pxHv/5Kdt2+e1/8YCtBD4eW+K4GIIr1CRv5LSG0J7NMG2VqX/Tbi3kZpDLWE8fEcveG/0RQJTs2jFu6q4kIibzYtsxeXUrEgsMnlDAXaH/+VnWBZ4+nqpSsN7vmlo124c9PC SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2018 01:04:17.3603 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 16ce2ba4-d18a-4c55-3fca-08d5530f1580 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR05MB0859 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 1/3/2018 2:40 PM, Arnd Bergmann wrote: > The uplink_rpriv variable was added at the start of the function but > only used inside of an #ifdef: > > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c: In function 'mlx5e_route_lookup_ipv6': > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c:1549:25: error: unused variable 'uplink_rpriv' [-Werror=unused-variable] > > This moves the declaration into that #ifdef as well. > > Fixes: 5ed99fb421d4 ("net/mlx5e: Move ethernet representors data into separate struct") > Signed-off-by: Arnd Bergmann Acked-by: Saeed Mahameed Thank you Arnd.