Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752046AbeADHXA (ORCPT + 1 other); Thu, 4 Jan 2018 02:23:00 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:51391 "EHLO huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751066AbeADHW7 (ORCPT ); Thu, 4 Jan 2018 02:22:59 -0500 Subject: Re: [PATCH v4] f2fs: check segment type in __f2fs_replace_block To: Jaegeuk Kim , Yunlong Song CC: , , , , , , , , References: <1514619768-134531-1-git-send-email-yunlong.song@huawei.com> <1515049322-29555-1-git-send-email-yunlong.song@huawei.com> <20180104071054.GD54234@jaegeuk-macbookpro.roam.corp.google.com> From: Chao Yu Message-ID: <9344a0ca-960c-3643-e360-433b70b05516@huawei.com> Date: Thu, 4 Jan 2018 15:22:45 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20180104071054.GD54234@jaegeuk-macbookpro.roam.corp.google.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 2018/1/4 15:10, Jaegeuk Kim wrote: > On 01/04, Yunlong Song wrote: >> In some case, the node blocks has wrong blkaddr whose segment type is >> NODE, e.g., recover inode has missing xattr flag and the blkaddr is in >> the xattr range. Since fsck.f2fs does not check the recovery nodes, this >> will cause __f2fs_replace_block change the curseg of node and do the >> update_sit_entry(sbi, new_blkaddr, 1) with no next_blkoff refresh, as a >> result, when recovery process write checkpoint and sync nodes, the >> next_blkoff of curseg is used in the segment bit map, then it will >> cause f2fs_bug_on. So let's check segment type in __f2fs_replace_block. >> >> Signed-off-by: Yunlong Song >> --- >> fs/f2fs/segment.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c >> index 890d483..50575d5 100644 >> --- a/fs/f2fs/segment.c >> +++ b/fs/f2fs/segment.c >> @@ -2720,6 +2720,7 @@ void __f2fs_replace_block(struct f2fs_sb_info *sbi, struct f2fs_summary *sum, >> type = se->type; >> >> down_write(&SM_I(sbi)->curseg_lock); >> + f2fs_bug_on(sbi, se->valid_blocks && !IS_DATASEG(type)); > > Let me just move this below like this and start some tests. > > ... > > + f2fs_bug_on(sbi, !IS_DATASEG(type)); Better, Reviewed-by: Chao Yu Thanks, > curseg = CURSEG_I(sbi, type); > >> >> if (!recover_curseg) { >> /* for recovery flow */ >> -- >> 1.8.5.2 > > . >