Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752541AbeADJZ4 (ORCPT + 1 other); Thu, 4 Jan 2018 04:25:56 -0500 Received: from mail-eopbgr60067.outbound.protection.outlook.com ([40.107.6.67]:22311 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751653AbeADJZM (ORCPT ); Thu, 4 Jan 2018 04:25:12 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=tariqt@mellanox.com; Subject: Re: ethernet: mlx4: Delete an error message for a failed memory allocation in five functions To: SF Markus Elfring , Tariq Toukan , linux-rdma@vger.kernel.org, netdev@vger.kernel.org Cc: Julia Lawall , LKML , kernel-janitors@vger.kernel.org References: <30191db0-4d99-0349-b66a-c7354ef90d50@users.sourceforge.net> <0fea8f2f-f8fc-ce2e-3d33-44227de3637a@mellanox.com> From: Tariq Toukan Message-ID: Date: Thu, 4 Jan 2018 11:24:56 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [193.47.165.251] X-ClientProxiedBy: DB6PR07CA0018.eurprd07.prod.outlook.com (2603:10a6:6:2d::28) To HE1PR05MB1147.eurprd05.prod.outlook.com (2a01:111:e400:50a6::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b2f71972-77fb-45c6-abc5-08d553550a1d X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(48565401081)(2017052603307)(7153060);SRVR:HE1PR05MB1147; X-Microsoft-Exchange-Diagnostics: 1;HE1PR05MB1147;3:KlRBaJSanQT9sVUtk91GfXHVhSmqKr6SH1fjVRIiJ8umNnZeA5TaCPdsA33TNK+8iQKTlr+R8JeMXDlvhZ0K9QYOaxFqP042AvUjjK1wQSJd1qnyQTUagUHTqPTZidX8+28aFpAXgeOUloWgqrWp4jS0qGmrbpom+td+qtAgW6iYGcrTSLdemXgmwujwceQYoavTE9MXKpU0XH6Towuode/0X6OyVQfTCfXw6/KgU2khTWth8SDt1/y2yjhsPYyP;25:19CoVQgbwRPAjdEgtSCQ13V91WZ7lkx90laMG7lQLiMYXmfsfC3PPn3F9DU1/teeStpM0Q1oTJlhn0w/fG40r4g9Trun+IiB1ELGmq2aInNPFjrGv5lYemqXyu/4nq9yluks6btqSpY+RfzNOzP/c+QjWXxgCLMFvK79z5zbRlsstRN/pF6gx4OrDDcp/pt3JYrXXauoez38auDSP/lGxffoDnamh1ps9bILQ6/dOYTvk2lRFZq7vD7mQGHagEliEcB5QFQS0EpivHYwRR2ziRDpVPa6b/Rcyj8daU5oDbU1VCFGH95M9xxYsBzJQfuGYiAxQYBrenBBRfutack+bw==;31:GEu0xa0uv2lZ81K6VD6HG73dTn6Q+/VqzxEvmeZg0iz17Dfb9g1vxSu/i43V9U89M3G5pE8BAJhJl46NUemGt0KpCe6+VbjE+tZvg8CCMkVixR50PUPSvAjdsQ1/JBjmmbrQ4a6xGv1f0wyOgFPewEhglHFsYHLU3bsVC50vMBRhup1R1CsIABXZpySlUEWdmMzCZqadV2Kcn094p/YJ/r1+/Q3kVt8Xo0L8AVDZ0ew= X-MS-TrafficTypeDiagnostic: HE1PR05MB1147: X-Microsoft-Exchange-Diagnostics: 1;HE1PR05MB1147;20:fzPBP/kXeRtpn20R7UqwA8pPJsj6KGIjlVinxUOO36S7x6zC5FLIDSZYAJY5UcFTlpcxX2or54Qxjplx6tOLt9cK8DwtqOKLLT/yobtJTC6d/XwYBahSWVshg4ydTy51zHebhAOQkMCqMAmjhKHocWH6hNcQEX/t9/TCU9gWAgq6CnyWz53M0KHEkMVuxU9+XitGch6p557WFPq0H0pJmvHeXDNhA/9cNuvfIrnWSZgdVRsaJ//BioUAX6PHtU+TH6Vk3K71tu+24tlPjFnKHK81Hktr+KUfmhYza39h3Whq1gonqJpIkws/5MOqk1vg0M2siIxJEFoZbJe79brfV2tGtIz6D+khrm+NrovHnID5xdn0B4/1q/U5KNYYGwLpuEblHxi/pnD2kaeIo4cbZlYDovV11DXoaGNRR+ABC5LtGVk6X4aYL0lVRoBUoFTRGhGgwhP81Enyxp2ONT7gy6QUybia1DlfkGz4Mn7ttl+x2odNDIPWivgtxmGPP+1K;4:OAImkLu/QGs5qxNwpz4j7mAelHrcE+Ojn3hPmjcvTj8FiRKWKU9QsH61in3ikUjpiFdGSZaF7bCK2LeAw/jFJ6VyvmAmFN77w+tTIWCEf4lnf0m+sI3wpA/8TEsXiebVfIHQV5Y673LMA4B7XYyh+21x0XzYwsr+iP5eTdrsvNPDgPDyFJUhzWlMrXKLXrUIovKTvEilLms1UJq/csXq9UO23WGiOtvGmqbc8x7BL0Lcu+jj3xP3zz9g/6GdVxKKAc708HF1SMicD8M3VzwLgyNkkyMqh+uoG+svtp4SvqCfPkpeuKF3i3jxx8C/Fxqq X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231023)(944501075)(10201501046)(3002001)(6055026)(6041268)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011);SRVR:HE1PR05MB1147;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:HE1PR05MB1147; X-Forefront-PRVS: 054231DC40 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(39860400002)(376002)(39380400002)(346002)(396003)(366004)(199004)(189003)(24454002)(25786009)(83506002)(65826007)(50466002)(64126003)(386003)(305945005)(2870700001)(105586002)(97736004)(6486002)(10710500007)(106356001)(7736002)(229853002)(16576012)(93886005)(316002)(77096006)(53546011)(15650500001)(5660300001)(2420400007)(47776003)(7110500001)(2906002)(66066001)(86362001)(4326008)(65956001)(68736007)(31696002)(16526018)(53936002)(6666003)(478600001)(58126008)(36756003)(65806001)(2950100002)(8936002)(966005)(6116002)(3846002)(52116002)(52146003)(81166006)(23676004)(2486003)(110136005)(54906003)(76176011)(31686004)(67846002)(8676002)(6306002)(6246003)(81156014);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR05MB1147;H:[10.8.0.245];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtIRTFQUjA1TUIxMTQ3OzIzOnRvY1hzSjZXY2EvamxncVAyMzRHa1ZPdWN3?= =?utf-8?B?eWE5SHdWTlE5a05jcGxBak9nVVQxUXA1MVEyTTN2d1YzSVRQazc5WXhDK1lp?= =?utf-8?B?eEJ0RUZtZFpKTkFVOFVZb2ozMUdyT3l4cWFGeXZxNEtwYzZBVnVBMU1zdGpk?= =?utf-8?B?UjY3dEhkWDhrSGVYT3Yxbm0yVlB6WmtFTUVZMGhVejZLYkg5WjcxQmZmblBk?= =?utf-8?B?Rmk1QnNBRVlWeXhvRG1HYnhqSWFFV0hyQ0Q1S2RHYzZVTkhwMkMvQkZnUDRS?= =?utf-8?B?OFFqMFF3Y3NKN3JnejNjWE9QZUd0NXdGNkJ2SGJMM1V0RWJZN3U5b3dnMGxG?= =?utf-8?B?bHlXTGlISitYbFg5UzAzVUU0a3A0RGdnZ21XcHYvSFlOQWhwZzM2UEVuZ2dS?= =?utf-8?B?aHBqcGpuWjlucGFta0NIbGxvZldjd0hha2NLYUlQM2VrSStCaVUzTCtMMkY1?= =?utf-8?B?UDdCWmRjM2dOU1N5WWRZQUVlcGFPQVdjZko1RlJyOFNPM0plR1dhcHE5WlJV?= =?utf-8?B?aCtSbFlpR3dvVlZPMTFEczRsM1krT05YS25SREErOTIxWEZNUW5CTWw0cCtD?= =?utf-8?B?TlFlSEpITmgvOUhNUUJqRVhwN0xzNS9vQms1Z3hndHJCaExsT1VESTJ4WUJU?= =?utf-8?B?VXVJVXZId3RBSG5jT3FENEVkL0l3ZXFuZExMa2t1eThZUDlWRzhtakxJMS9w?= =?utf-8?B?SmNEZFYxRXJYSWYvdXhLNS8xeVNVZi9oUllqaFlpaUFnQUtKeThsWUtJVjhy?= =?utf-8?B?RU1BbHVrN3dQUmhQMjArZzhvQUlEU3p6dk1TYWc5QzVmWUhuSlorREg5VWR4?= =?utf-8?B?bUpPcmkwaEJRNXgrcUNZZEtYSkRQdW00a0d2MWhMNWlwbEZUVkFrN3hveTFM?= =?utf-8?B?TEFKTTJqYWZiS3VwZkxRTVN1Mlp2VHg5bUxUeDhuSUUrWmJSVUc5WCs4NnJl?= =?utf-8?B?K2xkY3NnZ28xUElsamRuM0hGWnRKYjAyWFFmQmFrdlcxWWt4VlRLcWZqOFFY?= =?utf-8?B?U1BZeCtIZjJUaWQ5UFI1TEs2Mmc2aGp1YkJSZDllc1MzbEY2TzBhYW12VFdT?= =?utf-8?B?dTV4dzV0MDlrcm1OUHVUSFFiOEx2NUdkeWJid1djRFZFMWFXYzhSMHNvSlkv?= =?utf-8?B?bGV2eHNoSmVBNERDeEdsc3JGTmxWOGFVazcxOXN6L0IzTGR6ZU5MckUvVGFj?= =?utf-8?B?bG1LU1pnREphSWZDU00rVFF2UEZ6RUhwTHNHTXJ2dWtqN21zczhwVlRaTlkw?= =?utf-8?B?RzVKbnp0Yk9KZDBhSzkvVHJwc2Z4UnNvd1gyVU1UdnhOK1JBQmJSYU1kNno2?= =?utf-8?B?NG14MUZNZUJkUkYrT0IzZE9WRUlwQU1PY3F6bHU2MzBnUmxsRy8vb2JqNXJ1?= =?utf-8?B?U1lEK091ck5BcEZUOThqQ0tVL2lNYytWUXlkbW5PcElHdHNJQThHQXVEem5D?= =?utf-8?B?Wm0zdDdTZ2oyQ3hkMVJuVzN6Z0E5c1N2ZUI0LzlSRTFqa0J2eTU0R1diVXhQ?= =?utf-8?B?YzJMYzNUeTVXa1VwM0dlNEZCWm93RGcrdWlUdGdhdnhIRWhCVmtBdHArQWpX?= =?utf-8?B?Q1BtU3VmbnR0R3lMTElzOU1TUms3eVRxOWhPelJ5OWdVSkVMVm5tTUhkOTRl?= =?utf-8?B?TllicUk0eWJhYSttNHVmclNyd1lyQ3lFWDdKdzJWazBBd2kzZmY5L1dZWWFS?= =?utf-8?B?UHhVMGFOOHg0US8yelM5aHZxaHo5eFZNK0Q5Um9ROFF5RW1Ecm9FRjFCMUdv?= =?utf-8?B?aWRFSlp0QWxlR0c4Q3padkNHM2V3UG4rcTBxWjJtY000UCtmWUoxNTlGblhI?= =?utf-8?B?K0VUb2hNMjkrQTZXTkMwazUwQVQ5WkpTMkVqMHErb0VDSTdNMGREQ3NZVE1u?= =?utf-8?B?SWtjWHUxc21KTkVCL1NoVzlYRG1YZlFmZmduMXg1VUdoSWNZSUZiUUUwcEUx?= =?utf-8?B?b0J3bkVDbTNOSzY5a2J5SjFRZXozRW9ZYUdUQjl0TmswcExKaFR3SklLM2Zt?= =?utf-8?B?ZGJwTnpvWmIwckY1TFJFNlFCZFBCcnFBeDVWMFpQZXNub2xwNWpDQjVoWnNJ?= =?utf-8?B?VVpHd1JxQmxRWllYVWtTb1ZzeHZpaGRqVFRUb25ZSUxDQzU0UGNLcksxd0ZK?= =?utf-8?B?TGc9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR05MB1147;6:L+LSLvaM2I5fDex9EZvVFT1iPEyzr6rel9LiHAGvHn4yfqyl5zSDM/CX3uBGcPVu0I2/OZKkAje7BgGxDJf1tMCyueqmIJixCo/VOTcPGqTg3p1jhh2TOBFGUkdIWAg7ozglhX5cbbd2DsjSe9QS80NiMP2AwiV7ol+gEsklvR9/e+JZk+QKB/QThc7rNRajPgEoElhNorVwFuH8iuDChOkNmYiCbWxcX4xy6XngWx9yYa/0A5/gR125L+hY4RViDqQuVYC+ZnSBn+9cN4wwvwk81a8EbEmfuLu3OyDilOArV97kKBrr8naHLBj6Ht+DD3cJKQCYH0AiWiPJAo2piesfbSB8Dl2nrQ/pUK3Vvro=;5:vr15msFL/PeXydH+NnJ0YKgJFJdyHIfdCuYBPG8chzlvDCtJCJp0Wa198fIlNz9oaEtS4nfNYDHL2bZQqDTCI/1bocNwrHC25CScFExPKOmx2oUQzbWoPb9Vnaw10e/tuQHQc24/o88c5Ul1e8zSYEd3dJ+9FUxDm0ZXzim3crk=;24:wGxciRcfICXRE7JAwObMl1ZO6jQ3Xyym3vaa//1lk7K3fkyN0ZVNyRmYAtXKG1I3ioyAn45S9PfDG4AVPES9JZA6ScIhvZz6MQkqZijoQUY=;7:Ghu+72v4cJQKq3WVntb9g3kZMjsANUTrSOqBwcLuL8iCtkIvD/MIKVrIMR0TE4C02QydI7KMmohPmqldjSZ8eQiNdnkCt71NXlO+rfqhU4gKbKdehEwWRRIITDBJGaARIuDp0PpG3hGniP8sstWofH2a479CQVnlMb4wbWs2ShQ6l/DuG8DH1C727riq0Fok4IHG8QPHSm6waWtWjNsHHWvjfBeRTKXH6tgrmxAfWMUZxJbIVyBRIjICZheBgTLy SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2018 09:25:03.8272 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b2f71972-77fb-45c6-abc5-08d553550a1d X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR05MB1147 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 03/01/2018 4:22 PM, SF Markus Elfring wrote: >> I don't really accept this claim... >> Short informative strings worth the tiny space they consume. > > There can be different opinions for their usefulness. > > >> In addition, some out-of-memory errors are recoverable, even though their backtrace is also printed. > > How do you think about to suppress the backtrace generation for them? > > OK, makes sense. >> For example, in function mlx4_en_create_cq (appears in patch) we have a first allocation attempt (kzalloc_node) > > Would it be helpful to pass the option “__GFP_NOWARN” there? > > I'll prepare a patch to use it. Will ack this patch for now. >> and a fallback (kzalloc). I'd prefer to state a clear error message only when both have failed, >> because otherwise the user might be confused whether the backtrace should indicate a malfunctioning interface, or not. > > Can the distinction become easier by any other means? > > Regards, > Markus > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >