Subject: Re: [PATCH -next] irqchip/ompic: fix return value check in
 ompic_of_init()
To: "weiyongjun (A)" <weiyongjun1@huawei.com>,
        Stafford Horne <shorne@gmail.com>
Cc: Jonas Bonn <jonas@southpole.se>,
        Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
        Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>,
        "openrisc@lists.librecores.org" <openrisc@lists.librecores.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <1514893639-70586-1-git-send-email-weiyongjun1@huawei.com>
 <20180103144129.GJ32243@lianli.shorne-pla.net>
 <6AADFAC011213A4C87B956458587ADB40131FAB5@dggemi507-mbx.china.huawei.com>
From: Marc Zyngier <marc.zyngier@arm.com>
Organization: ARM Ltd
Message-ID: <68282353-1c44-3d0f-32ec-23934fc19686@arm.com>
Date: Thu, 4 Jan 2018 09:57:42 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <6AADFAC011213A4C87B956458587ADB40131FAB5@dggemi507-mbx.china.huawei.com>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On 04/01/18 03:56, weiyongjun (A) wrote:
> On Wed, Jan 03, 2018 10:41 PM, Stafford Horne wrote:
>> On Tue, Jan 02, 2018 at 11:47:19AM +0000, Wei Yongjun wrote:
>>> In case of error, the function ioremap() returns NULL pointer not
>>> ERR_PTR(). The IS_ERR() test in the return value check should be
>>> replaced with NULL test.
>>
>> Thanks, I am not sure why I was using the *ERR*() macros.  2 questions:
>>
>>  - How did you notice this?
> 
> This is detected by Coccinelle semantic patch. 
> 
>>  - Should I pull this in through my tree or do you have another route? i.e.
>>    Marc?
> 
> Feel free to pull this through your tree.

That's for me to say... I'll take it.


Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...