From: Shivasharan Srikanteshwara 
        <shivasharan.srikanteshwara@broadcom.com>
References: <1514648877-7234-1-git-send-email-himanshujha199640@gmail.com>
In-Reply-To: <1514648877-7234-1-git-send-email-himanshujha199640@gmail.com>
MIME-Version: 1.0
Thread-Index: AQIfGhu588Ec9uxJKsVp1HDFET4iO6LK8rIg
Date: Thu, 4 Jan 2018 16:52:54 +0530
Message-ID: <c5c7c47e09294ac851265c887ab23fe9@mail.gmail.com>
Subject: RE: [PATCH] scsi: megaraid: Use zeroing memory allocator than allocator/memset
To: Himanshu Jha <himanshujha199640@gmail.com>,
        martin.petersen@oracle.com, jejb@linux.vnet.ibm.com
Cc: Kashyap Desai <kashyap.desai@broadcom.com>,
        Sumit Saxena <sumit.saxena@broadcom.com>,
        "PDL,MEGARAIDLINUX" <megaraidlinux.pdl@broadcom.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        mcgrof@kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org

> -----Original Message-----
> From: Himanshu Jha [mailto:himanshujha199640@gmail.com]
> Sent: Saturday, December 30, 2017 9:18 PM
> To: martin.petersen@oracle.com; jejb@linux.vnet.ibm.com
> Cc: kashyap.desai@broadcom.com; sumit.saxena@broadcom.com;
> shivasharan.srikanteshwara@broadcom.com;
> megaraidlinux.pdl@broadcom.com; linux-scsi@vger.kernel.org; linux-
> kernel@vger.kernel.org; mcgrof@kernel.org; Himanshu Jha
> <himanshujha199640@gmail.com>
> Subject: [PATCH] scsi: megaraid: Use zeroing memory allocator than
> allocator/memset
>
> Use pci_zalloc_consistent for allocating zeroed memory and remove
> unnecessary memset function.
>
> Done using Coccinelle.
> Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
> 0-day tested with no failures.
>
> Suggested-by: Luis R. Rodriguez <mcgrof@kernel.org>
> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
> ---
>  drivers/scsi/megaraid/megaraid_sas_base.c   | 19 ++++++-------------
>  drivers/scsi/megaraid/megaraid_sas_fusion.c |  5 ++---
>  2 files changed, 8 insertions(+), 16 deletions(-)
>

Hi Himanshu,
I can see one more allocation done in megasas_get_seq_num() that could
make use of these changes.
Rest of the changes looks fine.

Also, there is a driver update patchset that I am planning to post today.
Adding this patch first might require additional rebasing of this
patchset.
Would you be ok if I send a separate patch for this along with the change
mentioned above once my patch series gets committed?
That would save me some rebasing effort. :-)

Thanks,
Shivasharan