Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752901AbeADLq6 (ORCPT + 1 other); Thu, 4 Jan 2018 06:46:58 -0500 Received: from foss.arm.com ([217.140.101.70]:59654 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752775AbeADLqz (ORCPT ); Thu, 4 Jan 2018 06:46:55 -0500 Cc: Sudeep Holla , "Rafael J. Wysocki" , "Rafael J. Wysocki" , ACPI Devel Maling List , "linux-arm-kernel@lists.infradead.org" , Hanjun Guo , Lorenzo Pieralisi , Will Deacon , Catalin Marinas , Greg Kroah-Hartman , Viresh Kumar , Mark Rutland , Linux Kernel Mailing List , Linux PM , jhugo@codeaurora.org, wangxiongfeng2@huawei.com, Jonathan.Zhang@cavium.com, Al Stone , Jayachandran.Nair@cavium.com, austinwc@codeaurora.org, Len Brown Subject: Re: [PATCH v5 4/9] drivers: base cacheinfo: Add support for ACPI based firmware tables To: Jeremy Linton References: <20171201222330.18863-1-jeremy.linton@arm.com> <20171201222330.18863-5-jeremy.linton@arm.com> <2078459.JrYtfXc8fv@aspire.rjw.lan> <5024a041-2ef4-3912-994f-b5fcc945e916@arm.com> <9bb1c58a-8d48-9952-e292-60b2bcb87a51@arm.com> <3c3bf8a4-a13a-ce71-4bd2-71dd11b45521@arm.com> From: Sudeep Holla Organization: ARM Message-ID: <0c7e176a-cdd4-aceb-7f38-cda38acb89c1@arm.com> Date: Thu, 4 Jan 2018 11:46:49 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <3c3bf8a4-a13a-ce71-4bd2-71dd11b45521@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 03/01/18 14:21, Sudeep Holla wrote: > On 12/12/17 23:37, Jeremy Linton wrote: >> On 12/12/2017 05:02 PM, Rafael J. Wysocki wrote: > > [...] > >>> >>> So call this field "token" or similar.  Don't call it "of_node" and >>> don't introduce another "firmware_node" thing in addition to that. >>> That just is a mess, sorry. > > I completely agree. Both me and Lorenzo pointed that out in previous > revisions and fair enough you have a valid concern it's use with PPTT. > >> >> I sort of agree, I think I can just change the whole of_node to a >> generic 'void *firmware_unique' which works fine for the PPTT code, it >> should also work for the DT code in cache_leaves_are_shared(). >> > > Should be fine. > Just to let you know, I don't have much to add. I will wait for the patches that replace of_node with firmware cookie or something similar. -- Regards, Sudeep