Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753017AbeADMC7 (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Thu, 4 Jan 2018 07:02:59 -0500
Received: from heliosphere.sirena.org.uk ([172.104.155.198]:40812 "EHLO
        heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752878AbeADMC5 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 4 Jan 2018 07:02:57 -0500
Date: Thu, 4 Jan 2018 12:02:44 +0000
From: Mark Brown <broonie@kernel.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: srinivas.kandagatla@linaro.org, Andy Gross <andy.gross@linaro.org>,
        linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
        David Brown <david.brown@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Patrick Lai <plai@codeaurora.org>,
        Banajit Goswami <bgoswami@codeaurora.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, linux-soc@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND PATCH v2 14/15] ASoC: qcom: apq8096: Add db820c machine
 driver
Message-ID: <20180104120244.GE10774@sirena.org.uk>
References: <20171214173402.19074-1-srinivas.kandagatla@linaro.org>
 <20171214173402.19074-15-srinivas.kandagatla@linaro.org>
 <f72f32dd-e248-47c3-23cc-eabe1b85d9ae@codeaurora.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="sfyO1m2EN8ZOtJL6"
Content-Disposition: inline
In-Reply-To: <f72f32dd-e248-47c3-23cc-eabe1b85d9ae@codeaurora.org>
X-Cookie: In the next world, you're on your own.
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>


--sfyO1m2EN8ZOtJL6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jan 03, 2018 at 09:20:45AM -0800, Stephen Boyd wrote:
> On 12/14/2017 09:34 AM, srinivas.kandagatla@linaro.org wrote:

> > uThis patch adds support to DB820c machine driver.

> > +	ret = dma_coerce_mask_and_coherent(card->dev, DMA_BIT_MASK(32));

> Why do we need to do this? Can you add some sort of comment in the code
> about why?

And why are we applying DMA restrictions in a machine driver?

--sfyO1m2EN8ZOtJL6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlpOF+MACgkQJNaLcl1U
h9DqSAf/TRTXDKdOETvzPNSKGaWNVG2ljRSTEBuPrReetgJ+PI1o30yx4FGcKhyV
MiDyv/O+wn1bkKSZ9o3TpSbz+e1Vwk/ceFEKrNwPxT1iK7Z2gqP0VbrnJ3g7nAjq
l2A2PvlIuZA8gD0F19g8r9dXgTLiuWSxduYY4YZIK4ns9JmSZi+VyfAwL/p2pKE4
EQkGHDmfm9x3vC85U1x2G4Bc+f8LmFWQhc3tbuxeqkZz1S/AK5IDzvpAPG93jCvx
QqaxW6uHYkYhZgqQJxojomPmkzWvT83YrsSbVlsRit1lQE2PQYBuKm+exmkWQJb5
nrZGGyAF1SzKBMfd6IrccOWBQOwwSA==
=5JJo
-----END PGP SIGNATURE-----

--sfyO1m2EN8ZOtJL6--