Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753100AbeADOBX (ORCPT + 1 other); Thu, 4 Jan 2018 09:01:23 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:46620 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752732AbeADOBV (ORCPT ); Thu, 4 Jan 2018 09:01:21 -0500 Date: Thu, 4 Jan 2018 15:01:19 +0100 From: Maxime Ripard To: Chen-Yu Tsai Cc: Emmanuel Vadot , Mark Rutland , devicetree , linux-kernel , Russell King , linux-sunxi , Rob Herring , Srinivas Kandagatla , Kyle Evans , linux-arm-kernel Subject: Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t Message-ID: <20180104140119.5pyfihp4zs2poz35@flea.lan> References: <20171219210523.10428-1-kevans91@ksu.edu> <20171221145512.llxvzkcrjpquhczi@flea.lan> <20171221152630.2vf57x5o2yi5sv3n@flea.lan> <20171221190903.56ebae536acf51401c63802c@bidouilliste.com> <20171222083508.dfcp6egfvxykmogg@flea.lan> <20171222110727.520df7394234f6a5dc0b9ec0@bidouilliste.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6jzbiftuhhovc4m5" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171208 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: --6jzbiftuhhovc4m5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 22, 2017 at 06:11:52PM +0800, Chen-Yu Tsai wrote: > On Fri, Dec 22, 2017 at 6:07 PM, Emmanuel Vadot w= rote: > > On Fri, 22 Dec 2017 09:35:08 +0100 > > Maxime Ripard wrote: > > > >> On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: > >> > > >> > Hi Maxime, > >> > > >> > On Thu, 21 Dec 2017 16:26:30 +0100 > >> > Maxime Ripard wrote: > >> > > >> > > Hi, > >> > > > >> > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: > >> > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard > >> > > > wrote: > >> > > > > Hi Kyle, > >> > > > > > >> > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wro= te: > >> > > > >> Allwinner a83t has a 1 KB sid block with efuse for security r= ootkey and > >> > > > >> thermal calibration data, add node to describe it. > >> > > > >> > >> > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but i= t is > >> > > > >> supported in an external driver for FreeBSD. > >> > > > >> > >> > > > >> Signed-off-by: Kyle Evans > >> > > > > > >> > > > > The patch looks fine in itself, but we've had a number of issu= es with > >> > > > > the register layout (and access patterns) in the past, so I'd = rather > >> > > > > have something that works in Linux too if possible. > >> > > > > >> > > > I have a patch that I think should make it work fine on Linux [1= ], but > >> > > > I'm afraid I have little to no capability to test it myself and = so I > >> > > > did not add it as well. > >> > > > > >> > > > I do know that the rootkey is offset 0x200 into the given space = [2], > >> > > > as is the case with the H3, and that the readout quirk is not ne= eded. > >> > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space = as the > >> > > > H3, but I do know that thermal data can be found at 0x34 and 0x3= 8 in > >> > > > this space. > >> > > > >> > > Then maybe we should leave it aside until someone takes some time = on > >> > > the A83t. > >> > > >> > Take some time on the Linux driver and do not apply this patch for > >> > now you mean ? > >> > >> Yep. > >> > >> Maxime > > > > Since linux doesn't have the compatible in it's driver what would > > be the harm to add the node in the DTS ? If a quirks is needed because > > some region is weird this would go in the driver right ? I don't see a > > technical problem for adding this node right now. > > If Kyle confirm the lenght of the region and that no quirk is needed > > will it be enough ? >=20 > I guess I wasn't very clear. I'm OK with the patch going in. The device > node currently says nothing about how much efuse space there is. The > memory region covers that and the control section, and the size matches > what the memory map says. >=20 > The size and offset of the efuse space would be dealt with in the driver. Let's merge it then. Acked-by: Maxime Ripard Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --6jzbiftuhhovc4m5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIyBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlpOM64ACgkQ0rTAlCFN r3QbQA/4wK3cHYbwUfXwjpUAfNGpJuxplIs9c4RP0XdDXzdbLNI2RFN3bitja8+7 //vqJ03tph1mBz/oBQVPlgMQB75aFOA/vHkPsJyW1DwIA1PEPEcPQQ+NvmPdThyG sTutqomejM5RAI/75CijnOGnfxBg2QCw7ram6Qw5cLnQsX4dTpe75GM7sQ1Xr68S sh4vRDmvqFiUd+/ew54d9oEvnVhey1ovuwtDmaOfyQ4qhaRurr+7PxF7tMGjzxJw aEB+6+ERNN8vK7cTMvfBGpzEHPHxAI2w2kwwqdmedGSQQF6EEbGh9Kc+fbN+JQ90 npClu5W3gfT1jORPRmFtWITcpW9V12NzO3YM7NKdLrCRXzD2Dlzv8gL+L663LpYr HVLI012DsSSuVMUnXXWMZ7GuDyyatb6kNOwYr3F+LYgwm3OWSpqOkRZ6z4/p3PyZ gh542NpyYoCjPltaMZk8cKEPBdi0ttOa7YgU9CFng68Tk5foQvlJY7NFM5FJtOzO jtgtegHl0WCSCyqHPHAmokfgF7Xt809L866LJ41Djn7CzVS29G+0G2nESRJUg5aL JVMQRoGJ89s7c25AEZ0siYoSBoCA4lF6hZDN5NOhnKVVyN9T1SG5BQd6r52xbqVr nfWc25ERV6lTgy8lE0Hz27p7H0RX6ZYuQrxLn11ZBBJqH6wC7g== =54E2 -----END PGP SIGNATURE----- --6jzbiftuhhovc4m5--