Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753211AbeADOhX (ORCPT + 1 other); Thu, 4 Jan 2018 09:37:23 -0500 Received: from mail-pl0-f66.google.com ([209.85.160.66]:42935 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753174AbeADOhV (ORCPT ); Thu, 4 Jan 2018 09:37:21 -0500 X-Google-Smtp-Source: ACJfBoumtME6AdJqKH+7txzwj5UsTPq48nmJ/vMAuWJXnuymkjStwupXESXMXd49HYE03t+vu53gGA== Date: Thu, 4 Jan 2018 20:07:14 +0530 From: Aishwarya Pant To: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Julia Lawall , Joe Perches Subject: [PATCH 1/5] iio: buffer: use permission specific variants of DEVICE_ATTR Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: This is a clean-up patch which replaces DEVICE_ATTR macro with the file permission specific DEVICE_ATTR_{RO/WO/RW} macros for compaction and readability. Done using coccinelle. Signed-off-by: Aishwarya Pant --- drivers/iio/industrialio-buffer.c | 25 +++++++++++-------------- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c index d2b465140a6b..ca565fbcff90 100644 --- a/drivers/iio/industrialio-buffer.c +++ b/drivers/iio/industrialio-buffer.c @@ -497,7 +497,7 @@ static int iio_buffer_add_channel_sysfs(struct iio_dev *indio_dev, return ret; } -static ssize_t iio_buffer_read_length(struct device *dev, +static ssize_t length_show(struct device *dev, struct device_attribute *attr, char *buf) { @@ -507,7 +507,7 @@ static ssize_t iio_buffer_read_length(struct device *dev, return sprintf(buf, "%d\n", buffer->length); } -static ssize_t iio_buffer_write_length(struct device *dev, +static ssize_t length_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t len) { @@ -540,7 +540,7 @@ static ssize_t iio_buffer_write_length(struct device *dev, return ret ? ret : len; } -static ssize_t iio_buffer_show_enable(struct device *dev, +static ssize_t enable_show(struct device *dev, struct device_attribute *attr, char *buf) { @@ -1117,7 +1117,7 @@ void iio_disable_all_buffers(struct iio_dev *indio_dev) iio_buffer_deactivate_all(indio_dev); } -static ssize_t iio_buffer_store_enable(struct device *dev, +static ssize_t enable_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t len) @@ -1153,7 +1153,7 @@ static ssize_t iio_buffer_store_enable(struct device *dev, static const char * const iio_scan_elements_group_name = "scan_elements"; -static ssize_t iio_buffer_show_watermark(struct device *dev, +static ssize_t watermark_show(struct device *dev, struct device_attribute *attr, char *buf) { @@ -1163,7 +1163,7 @@ static ssize_t iio_buffer_show_watermark(struct device *dev, return sprintf(buf, "%u\n", buffer->watermark); } -static ssize_t iio_buffer_store_watermark(struct device *dev, +static ssize_t watermark_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t len) @@ -1198,16 +1198,13 @@ static ssize_t iio_buffer_store_watermark(struct device *dev, return ret ? ret : len; } -static DEVICE_ATTR(length, S_IRUGO | S_IWUSR, iio_buffer_read_length, - iio_buffer_write_length); +static DEVICE_ATTR_RW(length); static struct device_attribute dev_attr_length_ro = __ATTR(length, - S_IRUGO, iio_buffer_read_length, NULL); -static DEVICE_ATTR(enable, S_IRUGO | S_IWUSR, - iio_buffer_show_enable, iio_buffer_store_enable); -static DEVICE_ATTR(watermark, S_IRUGO | S_IWUSR, - iio_buffer_show_watermark, iio_buffer_store_watermark); + S_IRUGO, length_show, NULL); +static DEVICE_ATTR_RW(enable); +static DEVICE_ATTR_RW(watermark); static struct device_attribute dev_attr_watermark_ro = __ATTR(watermark, - S_IRUGO, iio_buffer_show_watermark, NULL); + S_IRUGO, watermark_show, NULL); static struct attribute *iio_buffer_attrs[] = { &dev_attr_length.attr, -- 2.15.1