Date: Thu, 4 Jan 2018 17:55:22 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Xiongwei Song <sxwjean@gmail.com>
Cc: gregkh@linuxfoundation.org, arve@android.com, tkjos@android.com,
        maco@android.com, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: android: check the return value of
 register_shrinker
Message-ID: <20180104145522.ru7twjwzmzzrqatd@mwanda>
References: <20180104000853.1142-1-sxwjean@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180104000853.1142-1-sxwjean@gmail.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org

On Thu, Jan 04, 2018 at 08:08:53AM +0800, Xiongwei Song wrote:
> register_shrinker call is made in ashmem_init, it may return error code,
> so we need to check it.
> 
> Signed-off-by: Xiongwei Song <sxwjean@gmail.com>
> ---
>  drivers/staging/android/ashmem.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
> index 4e8947923904..0b23c3e25cd4 100644
> --- a/drivers/staging/android/ashmem.c
> +++ b/drivers/staging/android/ashmem.c
> @@ -854,12 +854,18 @@ static int __init ashmem_init(void)
>  		goto out_free2;
>  	}
>  
> -	register_shrinker(&ashmem_shrinker);
> +	ret = register_shrinker(&ashmem_shrinker);
> +	if (unlikely(ret)) {

Don't add the unlikely() here.  It hurts readability and this is not a
fast path.  I know the other callers all have it...  :/

regards,
dan carpenter