MIME-Version: 1.0
In-Reply-To: <20180104145522.ru7twjwzmzzrqatd@mwanda>
References: <20180104000853.1142-1-sxwjean@gmail.com> <20180104145522.ru7twjwzmzzrqatd@mwanda>
From: Xiongwei Song <sxwjean@gmail.com>
Date: Thu, 4 Jan 2018 23:15:50 +0800
Message-ID: <CAEVVKH-RJoghp4Entg6J-mHbJACXcChX466Ws31a4hW5UJmWXA@mail.gmail.com>
Subject: Re: [PATCH] staging: android: check the return value of register_shrinker
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: gregkh@linuxfoundation.org, arve@android.com, tkjos@android.com,
        maco@android.com, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org

2018-01-04 22:55 GMT+08:00 Dan Carpenter <dan.carpenter@oracle.com>:
> On Thu, Jan 04, 2018 at 08:08:53AM +0800, Xiongwei Song wrote:
>> register_shrinker call is made in ashmem_init, it may return error code,
>> so we need to check it.
>>
>> Signed-off-by: Xiongwei Song <sxwjean@gmail.com>
>> ---
>>  drivers/staging/android/ashmem.c | 8 +++++++-
>>  1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
>> index 4e8947923904..0b23c3e25cd4 100644
>> --- a/drivers/staging/android/ashmem.c
>> +++ b/drivers/staging/android/ashmem.c
>> @@ -854,12 +854,18 @@ static int __init ashmem_init(void)
>>               goto out_free2;
>>       }
>>
>> -     register_shrinker(&ashmem_shrinker);
>> +     ret = register_shrinker(&ashmem_shrinker);
>> +     if (unlikely(ret)) {
>
> Don't add the unlikely() here.  It hurts readability and this is not a
> fast path.  I know the other callers all have it...  :/

OK. Thanks for your suggestion. I'll send v2 out.


Thanks,
Xiongwei

>
> regards,
> dan carpenter
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>