Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753410AbeADPxK (ORCPT + 1 other); Thu, 4 Jan 2018 10:53:10 -0500 Received: from one.firstfloor.org ([193.170.194.197]:41512 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753013AbeADPxJ (ORCPT ); Thu, 4 Jan 2018 10:53:09 -0500 Date: Thu, 4 Jan 2018 07:53:07 -0800 From: Andi Kleen To: "Woodhouse, David" Cc: "tglx@linutronix.de" , "andi@firstfloor.org" , "torvalds@linux-foundation.org" , "linux-kernel@vger.kernel.org" , "gregkh@linux-foundation.org" , "gnomes@lxorguk.ukuu.org.uk" , "tim.c.chen@linux.intel.com" , "dave.hansen@intel.com" Subject: Re: Avoid speculative indirect calls in kernel Message-ID: <20180104155307.ouazlqdczqkgd76e@two.firstfloor.org> References: <20180103230934.15788-1-andi@firstfloor.org> <20180104000927.co5umvfzfwliqvqt@two.firstfloor.org> <20180104001501.3jof7zkrfkehnd3r@two.firstfloor.org> <20180104002916.3ff66581@alans-desktop> <20180104004034.wouy454tjmitkm5g@two.firstfloor.org> <1515053753.12987.70.camel@amazon.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1515053753.12987.70.camel@amazon.co.uk> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: > +.macro JMP_THUNK reg:req > +#ifdef RETPOLINE > +???????ALTERNATIVE __stringify(jmp __x86.indirect_thunk.\reg), __stringify(jmp *%\reg), X86_FEATURE_IBRS_ATT > +#else > +???????jmp *\reg > +#endif > +.endm I remove that because what you're testing for doesn't exist in the tree yet. Yes it can be added later. Right now we just want a basic static version to work reliably. -Andi