Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752732AbeADSZi (ORCPT + 1 other); Thu, 4 Jan 2018 13:25:38 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:43010 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750959AbeADSZg (ORCPT ); Thu, 4 Jan 2018 13:25:36 -0500 Date: Thu, 4 Jan 2018 19:25:22 +0100 (CET) From: Thomas Gleixner To: Kees Cook cc: LKML , Peter Zijlstra , Andy Lutomirski , x86@kernel.org Subject: Re: PTI build regression with nvidia drivers In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Thu, 4 Jan 2018, Kees Cook wrote: > > This was pointed out in a few places, but not forwarded to lkml yet that I saw: > > https://devtalk.nvidia.com/default/topic/1028222/linux/lts-kernel-patch-for-intel-cpu-vulnerability-breaks-nvidia-driver/post/5230546 > > Before and after PTI, cpu_tlbstate is a GPL export: > > $ git show v4.14:arch/x86/mm/init.c | grep cpu_tlbstate > DEFINE_PER_CPU_SHARED_ALIGNED(struct tlb_state, cpu_tlbstate) = { > EXPORT_SYMBOL_GPL(cpu_tlbstate); > > But after PTI, inlining or something is dragging cpu_tlbstate into the > open, causing build failures. > > Technically, to avoid regressions for that module, we'll need to drop > the GPL marking on that symbol, or find some other solution... Correct. It's indirect via the tlbflush inlines. We'll fix it as usual. Sigh.... Thanks, tglx