Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752887AbeADSw7 (ORCPT + 1 other); Thu, 4 Jan 2018 13:52:59 -0500 Received: from mail-yw0-f180.google.com ([209.85.161.180]:34518 "EHLO mail-yw0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752780AbeADSw5 (ORCPT ); Thu, 4 Jan 2018 13:52:57 -0500 X-Google-Smtp-Source: ACJfBovQFIR+EyVtUt48kVpMFx5MlgTkwhCbHGs8xy74aYx5NemI1m2X4mjOcJRA+2JR/oF3xy7FoPJNWQ1XE73loF8= MIME-Version: 1.0 In-Reply-To: <4af2b714-245a-0f0d-5982-818d5f81cade@users.sourceforge.net> References: <6cdc726b-82bc-85b6-393b-0e2002c19341@users.sourceforge.net> <4af2b714-245a-0f0d-5982-818d5f81cade@users.sourceforge.net> From: =?UTF-8?B?TWFoZXNoIEJhbmRld2FyICjgpK7gpLngpYfgpLYg4KSs4KSC4KSh4KWH4KS14KS+4KSwKQ==?= Date: Thu, 4 Jan 2018 10:52:35 -0800 Message-ID: Subject: Re: bonding: Completion of error handling around bond_update_slave_arr() To: SF Markus Elfring Cc: linux-netdev , Andy Gospodarek , Jay Vosburgh , Veaceslav Falico , LKML , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Thu, Jan 4, 2018 at 12:19 AM, SF Markus Elfring wrote: >> If you see 8 out of 9 call sites in this file ignore the return value. > > How do you think about to fix error detection and corresponding > exception handling then? > If I understand your question correctly - not having memory is not a correctable error and hence there are consequences. In this case, the slave_arr is not going to be rebuilt and this might mean loosing packets (if the interface was dropped) or not using the interface to send packets if that was added (very unlikely case). From host's perspective, however, this might be the last thing you want to worry about when there is no memory left. > Regards, > Markus