Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753071AbeADTIg (ORCPT + 1 other); Thu, 4 Jan 2018 14:08:36 -0500 Received: from ale.deltatee.com ([207.54.116.67]:39526 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752663AbeADTIb (ORCPT ); Thu, 4 Jan 2018 14:08:31 -0500 From: Logan Gunthorpe To: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, linux-nvdimm@lists.01.org, linux-block@vger.kernel.org References: <20180104190137.7654-1-logang@deltatee.com> <20180104190137.7654-9-logang@deltatee.com> Message-ID: <4432ed79-e463-e868-64af-0f130dafb261@deltatee.com> Date: Thu, 4 Jan 2018 12:08:29 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180104190137.7654-9-logang@deltatee.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: linux-block@vger.kernel.org, linux-nvdimm@lists.01.org, linux-rdma@vger.kernel.org, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH 08/12] nvme-pci: clean up SMBSZ bit definitions X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 04/01/18 12:01 PM, Logan Gunthorpe wrote: > From: Christoph Hellwig > > Define the bit positions instead of macros using the magic values, > and move the expanded helpers to calculate the size and size unit into > the implementation C file. > > Signed-off-by: Christoph Hellwig Oops, I forgot: Signed-off-by: Logan Gunthorpe