Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753212AbeADTKr (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Thu, 4 Jan 2018 14:10:47 -0500
Received: from mga06.intel.com ([134.134.136.31]:11812 "EHLO mga06.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752565AbeADTKp (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 4 Jan 2018 14:10:45 -0500
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,315,1511856000"; 
   d="scan'208";a="18248820"
Subject: Re: [PATCH 7/7] x86/microcode: Recheck IBRS features on microcode
 reload
To: Borislav Petkov <bp@alien8.de>,
        Andrea Arcangeli <aarcange@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
        Andy Lutomirski <luto@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Greg KH <gregkh@linuxfoundation.org>,
        Dave Hansen <dave.hansen@intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Arjan Van De Ven <arjan.van.de.ven@intel.com>,
        linux-kernel@vger.kernel.org
References: <cover.1515086770.git.tim.c.chen@linux.intel.com>
 <a2092889d6d2198494d97a341ea0375a95d3b3bd.1515086770.git.tim.c.chen@linux.intel.com>
 <20180104182858.2nevvgeq5wdojz2w@pd.tnic> <20180104183430.GJ13348@redhat.com>
 <20180104185033.tsbijx32as6wqvye@pd.tnic>
From: Tim Chen <tim.c.chen@linux.intel.com>
Message-ID: <bb43ec41-bf1c-48ea-ef04-b3a76d3115c7@linux.intel.com>
Date: Thu, 4 Jan 2018 11:10:44 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.0
MIME-Version: 1.0
In-Reply-To: <20180104185033.tsbijx32as6wqvye@pd.tnic>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On 01/04/2018 10:50 AM, Borislav Petkov wrote:
> On Thu, Jan 04, 2018 at 07:34:30PM +0100, Andrea Arcangeli wrote:
>> void spec_ctrl_rescan_cpuid(void)
>> {
>> 	int cpu;
>>
>> 	if (use_ibp_disable)
>> 		return;
>> 	mutex_lock(&spec_ctrl_mutex);
>> 	if (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL ||
>> 	    boot_cpu_data.x86_vendor == X86_VENDOR_AMD) {
>> 		/* detect spec ctrl related cpuid additions */
>> 		init_scattered_cpuid_features(&boot_cpu_data);
> 
> You don't need to noodle through all the scattered features - just the
> two bits.
> 

Sure.  Will update in rev 2.

Tim