Date: Thu, 4 Jan 2018 11:44:06 -0800
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: timur@tabi.org, broonie@kernel.org, linux-kernel@vger.kernel.org,
        linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org,
        lgirdwood@gmail.com, fabio.estevam@nxp.com, caleb@crome.org,
        arnaud.mouiche@invoxia.com, lukma@denx.de, kernel@pengutronix.de
Subject: Re: [PATCH v1 05/15] ASoC: fsl_ssi: Clean up helper functions of
 trigger()
Message-ID: <20180104194405.GD27975@Asurada-Nvidia>
References: <1513702819-42310-1-git-send-email-nicoleotsuka@gmail.com>
 <1513702819-42310-6-git-send-email-nicoleotsuka@gmail.com>
 <59aa58b7-aeda-ef87-e150-9fec9c6229ae@maciej.szmigiero.name>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <59aa58b7-aeda-ef87-e150-9fec9c6229ae@maciej.szmigiero.name>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org

On Mon, Jan 01, 2018 at 10:59:30PM +0100, Maciej S. Szmigiero wrote:

> > +static void fsl_ssi_config_enable(struct fsl_ssi *ssi, bool tx)

> > +		srcr = vals[tx].srcr;
> > +		stcr = vals[tx].stcr;
> > +		sier = vals[tx].sier;
> 
> Implicit assumption here that RX == 0, TX == 1, as in the 03 patch.

Could replace it with "bool dir" as well. Thanks for the review.