Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753355AbeADU6Y (ORCPT + 1 other); Thu, 4 Jan 2018 15:58:24 -0500 Received: from pic75-3-78-194-244-226.fbxo.proxad.net ([78.194.244.226]:43724 "EHLO mail.corsac.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752601AbeADU6W (ORCPT ); Thu, 4 Jan 2018 15:58:22 -0500 X-Greylist: delayed 397 seconds by postgrey-1.27 at vger.kernel.org; Thu, 04 Jan 2018 15:58:22 EST Message-ID: <1515099096.30693.19.camel@debian.org> Subject: Re: [PATCH 5/7] x86: Use IBRS for firmware update path From: Yves-Alexis Perez To: Tim Chen , Thomas Gleixner , Andy Lutomirski , Linus Torvalds , Greg KH Cc: Dave Hansen , Andrea Arcangeli , Andi Kleen , Arjan Van De Ven , linux-kernel@vger.kernel.org, David Woodhouse Date: Thu, 04 Jan 2018 21:51:36 +0100 In-Reply-To: <8d3710432534b27d224283557c4629cd1aa5b0ea.1515086770.git.tim.c.chen@linux.intel.com> References: <8d3710432534b27d224283557c4629cd1aa5b0ea.1515086770.git.tim.c.chen@linux.intel.com> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-RpayKp/Hhr46FmSvTUXI" X-Mailer: Evolution 3.26.3-1 Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: --=-RpayKp/Hhr46FmSvTUXI Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2018-01-04 at 09:56 -0800, Tim Chen wrote: > @@ -44,6 +47,7 @@ static inline void apm_bios_call_asm(u32 func, u32 ebx_= in, > u32 ecx_in, > "=3DS" (*esi) > : "a" (func), "b" (ebx_in), "c" (ecx_in) > : "memory", "cc"); > + unprotected_formware_end(); Just an obvious typo (form/firm) but I thought I'd report it. > } > =20 > static inline bool apm_bios_call_simple_asm(u32 func, u32 ebx_in, > @@ -52,6 +56,7 @@ static inline bool apm_bios_call_simple_asm(u32 func, u= 32 > ebx_in, > int cx, dx, si; > bool error; > =20 > + unprotected_firmware_begin(); > /* > * N.B. We do NOT need a cld after the BIOS call > * because we always save and restore the flags. > @@ -68,6 +73,7 @@ static inline bool apm_bios_call_simple_asm(u32 func, u= 32 > ebx_in, > "=3DS" (si) > : "a" (func), "b" (ebx_in), "c" (ecx_in) > : "memory", "cc"); > + unprotected_formware_end(); > return error; > } Same here. --=20 Yves-Alexis --=-RpayKp/Hhr46FmSvTUXI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEE8vi34Qgfo83x35gF3rYcyPpXRFsFAlpOk9gACgkQ3rYcyPpX RFtVOQgA28UxRaF6ZC1CpuYv0nFHdrpp4QjzLQCG4OG5NS9xKAPbibMDmT21r0Cp wq86tN+mBPKhIt9z+QbqKIiNWW30FGI/TcJOVIQ3cDphxgF11BOEtv/QVtv4gfby 7iHS7SgnlSkqabdCTIqwLV1aCDCjioZGimVwB20rObbG4JfggealPMGtyGIfG2ge +JhOt1oXyLSGhKZT4RQdH9Q+LFP0FOK/llD/5hvkBJRjqBMGPKkon8OeT9nMEHI7 YfYeIdIYVjjkO50wMemk1NGJOZjhMyLWjRM+iSBj+cQ+4JjDAoHyiOT5NU6JxC9f FDZW5MNBaRPtx5JNXvVgGahZPeSfYA== =gluY -----END PGP SIGNATURE----- --=-RpayKp/Hhr46FmSvTUXI--