Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753347AbeADVNq (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Thu, 4 Jan 2018 16:13:46 -0500
Received: from mga11.intel.com ([192.55.52.93]:19751 "EHLO mga11.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752659AbeADVNp (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 4 Jan 2018 16:13:45 -0500
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,315,1511856000"; 
   d="scan'208";a="18284193"
Subject: Re: [PATCH 5/7] x86: Use IBRS for firmware update path
To: Yves-Alexis Perez <corsac@debian.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Andy Lutomirski <luto@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Greg KH <gregkh@linuxfoundation.org>
Cc: Dave Hansen <dave.hansen@intel.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Andi Kleen <ak@linux.intel.com>,
        Arjan Van De Ven <arjan.van.de.ven@intel.com>,
        linux-kernel@vger.kernel.org, David Woodhouse <dwmw@amazon.co.uk>
References: <cover.1515086770.git.tim.c.chen@linux.intel.com>
 <8d3710432534b27d224283557c4629cd1aa5b0ea.1515086770.git.tim.c.chen@linux.intel.com>
 <1515099096.30693.19.camel@debian.org>
From: Tim Chen <tim.c.chen@linux.intel.com>
Message-ID: <fe2784b3-2e5a-198c-eed6-83a6e8d3ebd1@linux.intel.com>
Date: Thu, 4 Jan 2018 13:13:44 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.0
MIME-Version: 1.0
In-Reply-To: <1515099096.30693.19.camel@debian.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On 01/04/2018 12:51 PM, Yves-Alexis Perez wrote:
> On Thu, 2018-01-04 at 09:56 -0800, Tim Chen wrote:
>> @@ -44,6 +47,7 @@ static inline void apm_bios_call_asm(u32 func, u32 ebx_in,
>> u32 ecx_in,
>>                   "=S" (*esi)
>>                 : "a" (func), "b" (ebx_in), "c" (ecx_in)
>>                 : "memory", "cc");
>> +       unprotected_formware_end();
> 
> Just an obvious typo (form/firm) but I thought I'd report it.
>>  }
>>  
>>  static inline bool apm_bios_call_simple_asm(u32 func, u32 ebx_in,
>> @@ -52,6 +56,7 @@ static inline bool apm_bios_call_simple_asm(u32 func, u32
>> ebx_in,
>>         int     cx, dx, si;
>>         bool    error;
>>  
>> +       unprotected_firmware_begin();
>>         /*
>>          * N.B. We do NOT need a cld after the BIOS call
>>          * because we always save and restore the flags.
>> @@ -68,6 +73,7 @@ static inline bool apm_bios_call_simple_asm(u32 func, u32
>> ebx_in,
>>                   "=S" (si)
>>                 : "a" (func), "b" (ebx_in), "c" (ecx_in)
>>                 : "memory", "cc");
>> +       unprotected_formware_end();
>>         return error;
>>  }
> 
> Same here.
> 

Thanks.  Noted.

Tim