Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753268AbeADVQx (ORCPT + 1 other); Thu, 4 Jan 2018 16:16:53 -0500 Received: from mail-pf0-f169.google.com ([209.85.192.169]:43282 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752659AbeADVQv (ORCPT ); Thu, 4 Jan 2018 16:16:51 -0500 X-Google-Smtp-Source: ACJfBouI5WaS9WClY1v5sXY+Txgk43za24K2HYiO8Z29JSPBkY9EIk4qrzbVh88pJuyi5xER0Wp/vg== Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: [PATCH 4.4 00/37] 4.4.110-stable review From: Andy Lutomirski X-Mailer: iPhone Mail (15C153) In-Reply-To: Date: Thu, 4 Jan 2018 13:16:47 -0800 Cc: Linus Torvalds , Thomas Voegtle , Greg Kroah-Hartman , Linux Kernel Mailing List , Andrew Morton , Guenter Roeck , Shuah Khan , patches@kernelci.org, Ben Hutchings , lkft-triage@lists.linaro.org, stable Content-Transfer-Encoding: 8BIT Message-Id: References: <20180103195056.837404126@linuxfoundation.org> <20180104195055.GA29809@kroah.com> To: Hugh Dickins Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: > On Jan 4, 2018, at 12:57 PM, Hugh Dickins wrote: > >> On Thu, Jan 4, 2018 at 12:43 PM, Andy Lutomirski wrote: >> >>>> On Jan 4, 2018, at 12:29 PM, Linus Torvalds wrote: >>>> >>>> On Thu, Jan 4, 2018 at 12:16 PM, Thomas Voegtle wrote: >>>> >>>> Attached a screenshot. >>>> Is that useful? Are there some debug options I can add? >>> >>> Not much of an oops, because the SIGSEGV happens in user space. The >>> only reason you get any kernel stack printout at all is because 'init' >>> dying will make the kernel print that out. >>> >>> The segfault address for init looks like the fixmap area to me (first >>> byte in the last page of the fixmap?). "Error 5" means that it's a >>> user-space read that got a protection fault. So it's not a LDT of GDT >>> update or anything like that, it's a normal access from user space (or >>> a qemu emulation bug, but that sounds unlikely). >>> >>> Is that the vsyscall page? >>> >>> Adding Luto to the participants. I think he noticed one of the >>> vsyscall patches missing earlier in the 4.9 series. Maybe the 4.4 >>> series had something similar.. >>> >> >> That's almost certainly it. > > I'm hopeless on the FIXMAP arithmetic, but I'm pretty sure that > ffffffffff5ff000 is either VSYSCALL page or PVCLOCK page (I think it > was VVAR page when init segfaulted on it in my 3.2). Nah, that's one page below VSYSCALL. Vvar is 0x7fff... I don't have the actual screenshot, I think. > > I'll forward Borislav's suggested 4.4 VSYSCALL patch from the kaiser > backports ml to Thomas, to see if that sorts his crash (forwarding in > the hope that gmail doesn't mess up the patch). > > Seems odd that 4.4 should be broken but 4.9 not broken here, I'd > expect them to be equally known broken with respect to VSYSCALL; but > perhaps it's a matter of userspace trying different fallbacks > according to what kernel supports, and only hitting this on 4.4. I don't think any current userspace is that dumb. But Go was still using vsyscall fairly recently. I may be able to look for real tonight. > > Hugh > >> >> I'll try to find some time today Thomnor tomorrow to add a proper selftest. >> >>> Linus