Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751410AbeAEAHX (ORCPT + 1 other); Thu, 4 Jan 2018 19:07:23 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:43378 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751108AbeAEAHW (ORCPT ); Thu, 4 Jan 2018 19:07:22 -0500 Date: Fri, 5 Jan 2018 01:07:02 +0100 (CET) From: Thomas Gleixner To: Borislav Petkov cc: Andrea Arcangeli , Tim Chen , Peter Zijlstra , Andy Lutomirski , Linus Torvalds , Greg KH , Dave Hansen , Andi Kleen , Arjan Van De Ven , linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/7] x86/spec_ctrl: Add sysctl knobs to enable/disable SPEC_CTRL feature In-Reply-To: <20180104235908.xcfls5upmxmuxucl@pd.tnic> Message-ID: References: <4d4b3752e8e533201c6983d8473eea95c747ea33.1515086770.git.tim.c.chen@linux.intel.com> <20180104225422.GG32035@hirez.programming.kicks-ass.net> <20180104235134.GC13348@redhat.com> <20180104235908.xcfls5upmxmuxucl@pd.tnic> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Fri, 5 Jan 2018, Borislav Petkov wrote: > On Fri, Jan 05, 2018 at 12:51:34AM +0100, Andrea Arcangeli wrote: > > In older kernels there's not even the boilerplate to check the static > > key in asm, > > This is the reason why I didn't use a static_key too. We are talking about upstream first and given the amount of crap you backported already the few lines for the ASM jump labels really do not make a difference anymore. I so hope this exercise will finally stop the kernel-necrophilia in distros. I know it won't but hope dies last. Thanks, tglx