Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751660AbeAEEV7 (ORCPT + 1 other); Thu, 4 Jan 2018 23:21:59 -0500 Received: from mail-io0-f176.google.com ([209.85.223.176]:35027 "EHLO mail-io0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751476AbeAEEV5 (ORCPT ); Thu, 4 Jan 2018 23:21:57 -0500 X-Google-Smtp-Source: ACJfBovrIY1+dxu7Mjw7psIAhg/QZIQJZ5paMxap6M8Tt2bV28Oy2a0h8oFZODXKSR/9EHq+QCE7jZSBpH31nCfjO1E= MIME-Version: 1.0 In-Reply-To: <20180104120021.lilczus6qv7e4vcw@salmiak> References: <20180103223827.39601-1-mark.rutland@arm.com> <20180103223827.39601-2-mark.rutland@arm.com> <20180104120021.lilczus6qv7e4vcw@salmiak> From: Dan Williams Date: Thu, 4 Jan 2018 20:21:56 -0800 Message-ID: Subject: Re: [RFC PATCH 1/4] asm-generic/barrier: add generic nospec helpers To: Mark Rutland Cc: Linux Kernel Mailing List , linux-arch@vger.kernel.org, Will Deacon Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Thu, Jan 4, 2018 at 4:00 AM, Mark Rutland wrote: > On Wed, Jan 03, 2018 at 10:38:24PM +0000, Mark Rutland wrote: >> +#define nospec_array_load(arr, idx, sz) \ >> +({ \ >> + typeof(*(arr)) *__arr = arr; \ >> + typeof(idx) __idx = idx; \ >> + typeof(sz) __sz = __sz; \ > > Whoops. The second __sz should be sz here. Those should all have parenthesis on the args too, right?