MIME-Version: 1.0
In-Reply-To: <1513682145-19892-3-git-send-email-zhongkaihua@huawei.com>
References: <1513682145-19892-1-git-send-email-zhongkaihua@huawei.com> <1513682145-19892-3-git-send-email-zhongkaihua@huawei.com>
From: Jassi Brar <jassisinghbrar@gmail.com>
Date: Fri, 5 Jan 2018 09:58:57 +0530
Message-ID: <CABb+yY2z4jDWJdDY2WRw5Mhv+ArTuvLgqJ9RyVoUJj3O1d=o6A@mail.gmail.com>
Subject: Re: [PATCH v4 2/3] mailbox: Add support for Hi3660 mailbox
To: Kaihua Zhong <zhongkaihua@huawei.com>
Cc: Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Wei Xu <xuwei5@hisilicon.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>,
        Devicetree List <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        Guodong Xu <guodong.xu@linaro.org>,
        Haojian Zhuang <haojian.zhuang@linaro.org>,
        suzhuangluan@hisilicon.com, xuezhiliang@hisilicon.com,
        kevin.wangtao@hisilicon.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org

On Tue, Dec 19, 2017 at 4:45 PM, Kaihua Zhong <zhongkaihua@huawei.com> wrote:

.....
> diff --git a/drivers/mailbox/hi3660-mailbox.c b/drivers/mailbox/hi3660-mailbox.c
> new file mode 100644
> index 0000000..3ceca40
> --- /dev/null
> +++ b/drivers/mailbox/hi3660-mailbox.c
> @@ -0,0 +1,319 @@
> +// SPDX-License-Identifier: GPL-2.0
> +// Copyright (c) 2017 Hisilicon Limited.
> +// Copyright (c) 2017 Linaro Limited.

A blank here please.

> +#include <linux/bitops.h>
> +#include <linux/delay.h>
> +#include <linux/device.h>
> +#include <linux/err.h>
> +#include <linux/interrupt.h>
> +#include <linux/io.h>
> +#include <linux/iopoll.h>

.....
> +
> +static inline struct hi3660_mbox *to_hi3660_mbox(struct mbox_controller *mbox)
>
inline in .c is out of fasion these days
> +{
> +       return container_of(mbox, struct hi3660_mbox, controller);
> +}
> +

....
> +
> +static int hi3660_mbox_startup(struct mbox_chan *chan)
> +{
> +       int ret;
> +
> +       ret = hi3660_mbox_check_state(chan);
> +       if (ret)
> +               return ret;
> +
> +       ret = hi3660_mbox_unlock(chan);
> +       if (ret)
> +               return ret;
> +
> +       ret = hi3660_mbox_acquire_channel(chan);
> +       if (ret)
> +               return ret;
> +
> +       return 0;
> +}
Do you not need to do "release channel" for shutdown() ?

.....
> +
> +static int hi3660_mbox_send_data(struct mbox_chan *chan, void *msg)
> +{
> +       return hi3660_mbox_send(chan, msg);
>
Please directly have hi3660_mbox_send as .send_data

Cheers!