Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751360AbeAEHR1 (ORCPT + 1 other); Fri, 5 Jan 2018 02:17:27 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:3686 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751056AbeAEHR0 (ORCPT ); Fri, 5 Jan 2018 02:17:26 -0500 From: Wei Yongjun To: Jeff Dike , Richard Weinberger , "Anton Ivanov" CC: Wei Yongjun , , , Subject: [PATCH -next] um: vector: fix missing unlock on error in vector_net_open() Date: Fri, 5 Jan 2018 07:22:52 +0000 Message-ID: <1515136972-58532-1-git-send-email-weiyongjun1@huawei.com> X-Mailer: git-send-email 1.8.3.1 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Add the missing unlock before return from function vector_net_open() in the error handling case. Fixes: ad1f62ab2bd4 ("High Performance UML Vector Network Driver") Signed-off-by: Wei Yongjun --- arch/um/drivers/vector_kern.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c index d1d5301..bb83a2d 100644 --- a/arch/um/drivers/vector_kern.c +++ b/arch/um/drivers/vector_kern.c @@ -1156,8 +1156,10 @@ static int vector_net_open(struct net_device *dev) struct vector_device *vdevice; spin_lock_irqsave(&vp->lock, flags); - if (vp->opened) + if (vp->opened) { + spin_unlock_irqrestore(&vp->lock, flags); return -ENXIO; + } vp->opened = true; spin_unlock_irqrestore(&vp->lock, flags);