Date: Fri, 5 Jan 2018 09:15:29 +0000
From: Mark Rutland <mark.rutland@arm.com>
To: Dan Williams <dan.j.williams@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-arch@vger.kernel.org, Will Deacon <will.deacon@arm.com>
Subject: Re: [RFC PATCH 1/4] asm-generic/barrier: add generic nospec helpers
Message-ID: <20180105091529.b7jip2q4a44esmh4@salmiak>
References: <20180103223827.39601-1-mark.rutland@arm.com>
 <20180103223827.39601-2-mark.rutland@arm.com>
 <20180104120021.lilczus6qv7e4vcw@salmiak>
 <CAA9_cmcWHc_068kHEDQ2DNcTZNFBAypmkhznnVODKccnuLFFOg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAA9_cmcWHc_068kHEDQ2DNcTZNFBAypmkhznnVODKccnuLFFOg@mail.gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org

On Thu, Jan 04, 2018 at 08:21:56PM -0800, Dan Williams wrote:
> On Thu, Jan 4, 2018 at 4:00 AM, Mark Rutland <mark.rutland@arm.com> wrote:
> > On Wed, Jan 03, 2018 at 10:38:24PM +0000, Mark Rutland wrote:
> >> +#define nospec_array_load(arr, idx, sz)                                      \
> >> +({                                                                   \
> >> +     typeof(*(arr)) *__arr = arr;                                    \
> >> +     typeof(idx) __idx = idx;                                        \
> >> +     typeof(sz) __sz = __sz;                                         \
> >
> > Whoops. The second __sz should be sz here.
> 
> Those should all have parenthesis on the args too, right?

Probably, yes.

I've added those to the version in my core/nospec branch.

Thanks,
Mark.