Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751610AbeAEJwq (ORCPT + 1 other); Fri, 5 Jan 2018 04:52:46 -0500 Received: from mail-io0-f196.google.com ([209.85.223.196]:37502 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751322AbeAEJwn (ORCPT ); Fri, 5 Jan 2018 04:52:43 -0500 X-Google-Smtp-Source: ACJfBotpv5Eg9Mdmjufwxz/kjZEy8IWxj6NPtEpJM5eRUGB9QOryT0FVm5z8FL8SkWidAiqUVVtoPlZ6SdaDqXqtuws= MIME-Version: 1.0 In-Reply-To: References: From: Devesh Sharma Date: Fri, 5 Jan 2018 15:22:02 +0530 Message-ID: Subject: Re: [rdma for-next] bnxt_re: report RoCE device support at info level To: Jonathan Toppins Cc: linux-rdma , Selvin Xavier , Somnath Kotur , Sriharsha Basavapatna , Doug Ledford , Jason Gunthorpe , open list Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Acked-By: Devesh Sharma On Fri, Jan 5, 2018 at 2:34 AM, Jonathan Toppins wrote: > Reporting that a device doesn't support RoCE seems like a valuable piece > of information to have when trying to determine why a driver is not binding > to a device. Better to report this at info log level instead of requiring > a user to enable all debug messages in the driver. > > Signed-off-by: Jonathan Toppins > --- > drivers/infiniband/hw/bnxt_re/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c > index aafc19aa5de1..bf268bf1f496 100644 > --- a/drivers/infiniband/hw/bnxt_re/main.c > +++ b/drivers/infiniband/hw/bnxt_re/main.c > @@ -417,7 +417,7 @@ static struct bnxt_en_dev *bnxt_re_dev_probe(struct net_device *netdev) > return ERR_PTR(-EINVAL); > > if (!(en_dev->flags & BNXT_EN_FLAG_ROCE_CAP)) { > - dev_dbg(&pdev->dev, > + dev_info(&pdev->dev, > "%s: probe error: RoCE is not supported on this device", > ROCE_DRV_MODULE_NAME); > return ERR_PTR(-ENODEV); > -- > 2.13.6 >