Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751119AbeAEKHE (ORCPT + 1 other); Fri, 5 Jan 2018 05:07:04 -0500 Received: from mga11.intel.com ([192.55.52.93]:56708 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750907AbeAEKHC (ORCPT ); Fri, 5 Jan 2018 05:07:02 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,318,1511856000"; d="scan'208";a="8293842" Subject: Re: [alsa-devel] [PATCH 15/27] ALSA: hda - Use timecounter_initialize interface To: Pierre-Louis Bossart , Richard Cochran Cc: alsa-devel@alsa-project.org, Takashi Iwai , linux-kernel@vger.kernel.org, Vinod Koul , Thomas Gleixner References: <1513323522-15021-1-git-send-email-sagar.a.kamble@intel.com> <1513323522-15021-16-git-send-email-sagar.a.kamble@intel.com> <20171215165125.avkz25eek56i5md4@localhost> <20171228164944.crphv46zegvwautk@localhost> <1a9a1507-7ca3-459b-c2ce-02fc2afad2ff@intel.com> <3c5734a2-8f97-4a8b-26d4-42852cc86352@linux.intel.com> <20180102182146.vbfnihz73lhgf6lc@localhost> <9f09abee-68b8-4515-131f-0f3e210503b0@linux.intel.com> From: Sagar Arun Kamble Message-ID: Date: Fri, 5 Jan 2018 15:36:56 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <9f09abee-68b8-4515-131f-0f3e210503b0@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 1/3/2018 1:23 AM, Pierre-Louis Bossart wrote: > On 1/2/18 12:21 PM, Richard Cochran wrote: >> On Tue, Jan 02, 2018 at 11:15:45AM -0600, Pierre-Louis Bossart wrote: >>> I wrote the code for HDaudio and I remember wasting time trying to >>> figure >>> out the gory details of the cycle counter stuff when all I wanted was a >>> conversion from a 24MHz counter to ns values using a 125/3 operation >>> in the >>> right order - as explained in the comments >> >> Would using clocks_calc_mult_shift() work for you? > > In theory yes, but I'd need to re-check what the results would be. > I remember applying the 1/3 factor separately to avoid wrap-around > after 4 hours [1], but I can't remember the details on the analysis. I > can't figure out what the 'maxsec' argument should be either. > I am not sure if I understood the wrap-around correctly. Is AZX_REG_WALL_CLK 64bit or 32bit and in the comments which 20 bits are being referred. Keeping maxsec at lower value will ensure good precision but the mult factor derived then might lead to overflow if the interval of counter read is big. Keeping maxsec high will reduce the mult factor and will marginally impact the precision (of the order of 6 decimal places of fraction nano second). For 24mhz clock I am getting following scale factors at different maxsec values. I think these are as good as 125/3 125/3 gives scale factor of 41.666666666666666666666666666667 maxsec, mult, shift, scale factor (mult/(2^shift)) 0, 2796202667, 26,     41.66666667163372039794921875 3600, 87381333, 21,   41.666666507720947265625 14400, 21845333, 19, 41.6666660308837890625 I see sound driver uses only timecounter_read so conversions should be fine. If there are usages of timecounter_cyc2time then we will have to take care of updating the timecounter often as timecounter API internally counts time backwards if counter is spaced more than 1/2 the range. Thanks Sagar > [1] > http://elixir.free-electrons.com/linux/latest/source/sound/hda/hdac_stream.c#L486 >