Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751492AbeAEK30 (ORCPT + 1 other); Fri, 5 Jan 2018 05:29:26 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:43002 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750978AbeAEK3Z (ORCPT ); Fri, 5 Jan 2018 05:29:25 -0500 Subject: Re: [PATCH 04/11] arm64: cpufeature: Pass capability structure to ->enable callback To: Will Deacon , linux-arm-kernel@lists.infradead.org Cc: catalin.marinas@arm.com, ard.biesheuvel@linaro.org, marc.zyngier@arm.com, lorenzo.pieralisi@arm.com, christoffer.dall@linaro.org, linux-kernel@vger.kernel.org References: <1515078515-13723-1-git-send-email-will.deacon@arm.com> <1515078515-13723-5-git-send-email-will.deacon@arm.com> From: Suzuki K Poulose Message-ID: <707a2690-d41b-1453-65ef-ff8188f254d4@arm.com> Date: Fri, 5 Jan 2018 10:29:20 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1515078515-13723-5-git-send-email-will.deacon@arm.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 04/01/18 15:08, Will Deacon wrote: > In order to invoke the CPU capability ->matches callback from the ->enable > callback for applying local-CPU workarounds, we need a handle on the > capability structure. > > This patch passes a pointer to the capability structure to the ->enable > callback. > > Signed-off-by: Will Deacon > --- > arch/arm64/kernel/cpufeature.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > index e11c11bb5b02..6133c14b9b01 100644 > --- a/arch/arm64/kernel/cpufeature.c > +++ b/arch/arm64/kernel/cpufeature.c > @@ -1151,7 +1151,7 @@ void __init enable_cpu_capabilities(const struct arm64_cpu_capabilities *caps) > * uses an IPI, giving us a PSTATE that disappears when > * we return. > */ > - stop_machine(caps->enable, NULL, cpu_online_mask); > + stop_machine(caps->enable, (void *)caps, cpu_online_mask); > } > } > } > @@ -1194,7 +1194,7 @@ verify_local_cpu_features(const struct arm64_cpu_capabilities *caps) > cpu_die_early(); > } > if (caps->enable) > - caps->enable(NULL); > + caps->enable((void *)caps); > } > } > > Reviewed-by: Suzuki K Poulose