Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752182AbeAENTU (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Fri, 5 Jan 2018 08:19:20 -0500
Received: from Galois.linutronix.de ([146.0.238.70]:44487 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751751AbeAENTR (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 5 Jan 2018 08:19:17 -0500
Date: Fri, 5 Jan 2018 14:19:04 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Tim Chen <tim.c.chen@linux.intel.com>
cc: Peter Zijlstra <peterz@infradead.org>,
        Andy Lutomirski <luto@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Greg KH <gregkh@linuxfoundation.org>,
        Dave Hansen <dave.hansen@intel.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Andi Kleen <ak@linux.intel.com>,
        Arjan Van De Ven <arjan.van.de.ven@intel.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] x86/enter: MACROS to set/clear IBRS
In-Reply-To: <7fe03060-3904-dcf7-3cdf-a98ade5f5148@linux.intel.com>
Message-ID: <alpine.DEB.2.20.1801051410200.1724@nanos>
References: <cover.1515086770.git.tim.c.chen@linux.intel.com> <032e71e3826ed92523e9070fffa7108392848dc6.1515086770.git.tim.c.chen@linux.intel.com> <20180104221645.GC32035@hirez.programming.kicks-ass.net>
 <7fe03060-3904-dcf7-3cdf-a98ade5f5148@linux.intel.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Thu, 4 Jan 2018, Tim Chen wrote:
> On 01/04/2018 02:16 PM, Peter Zijlstra wrote:
> >> +	movl    \save_reg, %eax
> >> +	wrmsr
> >> +10:
> >> +.endm
> > 
> > Should not all those 10 things look like .Ldone_\@ or something ?
> > 
> 
> They are removed in patch 6 with .Ldone_\@

So we need to develop speculative review capabilities from now on?

Please get your act together and fold stuff to the right place upfront, so
we can concentrate on the actual implementation review.

Thanks,

	tglx