Date: Fri, 5 Jan 2018 14:40:32 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Tim Chen <tim.c.chen@linux.intel.com>
cc: Andy Lutomirski <luto@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Greg KH <gregkh@linuxfoundation.org>,
        Dave Hansen <dave.hansen@intel.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Andi Kleen <ak@linux.intel.com>,
        Arjan Van De Ven <arjan.van.de.ven@intel.com>,
        linux-kernel@vger.kernel.org, David Woodhouse <dwmw@amazon.co.uk>
Subject: Re: [PATCH 5/7] x86: Use IBRS for firmware update path
In-Reply-To: <8d3710432534b27d224283557c4629cd1aa5b0ea.1515086770.git.tim.c.chen@linux.intel.com>
Message-ID: <alpine.DEB.2.20.1801051438280.1724@nanos>
References: <cover.1515086770.git.tim.c.chen@linux.intel.com> <8d3710432534b27d224283557c4629cd1aa5b0ea.1515086770.git.tim.c.chen@linux.intel.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org

On Thu, 4 Jan 2018, Tim Chen wrote:
>  #ifdef APM_ZERO_SEGS
>  #	define APM_DO_ZERO_SEGS \
>  		"pushl %%ds\n\t" \
> @@ -28,6 +30,7 @@ static inline void apm_bios_call_asm(u32 func, u32 ebx_in, u32 ecx_in,
>  					u32 *eax, u32 *ebx, u32 *ecx,
>  					u32 *edx, u32 *esi)
>  {
> +	unprotected_firmware_begin();
>  	/*
>  	 * N.B. We do NOT need a cld after the BIOS call
>  	 * because we always save and restore the flags.
> @@ -44,6 +47,7 @@ static inline void apm_bios_call_asm(u32 func, u32 ebx_in, u32 ecx_in,
>  		  "=S" (*esi)
>  		: "a" (func), "b" (ebx_in), "c" (ecx_in)
>  		: "memory", "cc");
> +	unprotected_formware_end();

This doesn't even compile unless the new compiler speculates that into
unprotected_firmware_end().

Thanks,

	tglx