Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752009AbeAEOmr (ORCPT + 1 other); Fri, 5 Jan 2018 09:42:47 -0500 Received: from mx2.suse.de ([195.135.220.15]:56630 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751609AbeAEOmo (ORCPT ); Fri, 5 Jan 2018 09:42:44 -0500 Date: Fri, 5 Jan 2018 15:42:39 +0100 From: Petr Mladek To: Sergey Senozhatsky Cc: Andrew Morton , Russell King , Catalin Marinas , Mark Salter , Tony Luck , David Howells , Yoshinori Sato , Guan Xuetao , Borislav Petkov , Greg Kroah-Hartman , Thomas Gleixner , Peter Zijlstra , Vineet Gupta , Fengguang Wu , Steven Rostedt , LKML , linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org, linux-ia64@vger.kernel.org, linux-am33-list@redhat.com, linux-sh@vger.kernel.org, linux-edac@vger.kernel.org, x86@kernel.org, linux-snps-arc@lists.infradead.org, Sergey Senozhatsky Subject: Re: [PATCH 00/13] replace print_symbol() with printk()-s Message-ID: <20180105144239.i3pc6npgmoi4ddln@pathway.suse.cz> References: <20171211125025.2270-1-sergey.senozhatsky@gmail.com> <20180105100300.j3svmcvvpfe2iows@pathway.suse.cz> <20180105102105.GB471@jagdpanzerIV> <20180105102538.GC471@jagdpanzerIV> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180105102538.GC471@jagdpanzerIV> User-Agent: NeoMutt/20170421 (1.8.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Fri 2018-01-05 19:25:38, Sergey Senozhatsky wrote: > On (01/05/18 19:21), Sergey Senozhatsky wrote: > > On (01/05/18 11:03), Petr Mladek wrote: > > [..] > > > Anyway, print_symbol() is an old weird API and it would be nice > > > to eventually get rid of it. I could take this patches into > > > printk.git. > > > > no objections from my side if the patch set will go through the printk tree. > > shall we wait for ACKs or can we move on? do you plan to land it in 4.16? > > > > > Would you mind if I change the commit messages to something like?: > > > > > > print_symbol() is an old weird API. It has been > > > obsoleted by printk() and %pS format specifier. > > > > I wouldn't. let's drop the "weird" part. other than that looks > > good to me. > > oh, one more thing. one extra patch, which gets rid of > print_symbol()/__print_symbol(). I am all for it. But I would postpone this removal to 4.17. The reason is rather ugly. 13th patch is already in arc tree. We would need to shuffle the patch or coordinate pull requests. I think that it is not worth it. There is no real hurry. I doubt that the would be any new user in the meantime. Best Regards, Petr PS: I have just pushed 12 patches into printk.git for-4.16 branch. I will merge this to linux-next branch on Monday. I will not be around the computer over the weekend...