Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751911AbeAEPOu (ORCPT + 1 other); Fri, 5 Jan 2018 10:14:50 -0500 Received: from mail-by2nam01on0078.outbound.protection.outlook.com ([104.47.34.78]:36496 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751514AbeAEPOs (ORCPT ); Fri, 5 Jan 2018 10:14:48 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Thomas.Lendacky@amd.com; Subject: Re: [PATCH 1/7] x86/feature: Detect the x86 feature to control Speculation To: David Woodhouse , Tim Chen , Thomas Gleixner , Andy Lutomirski , Linus Torvalds , Greg KH Cc: Dave Hansen , Andrea Arcangeli , Andi Kleen , Arjan Van De Ven , linux-kernel@vger.kernel.org References: <427aa76dea14532dea7e49f0bce4e7cf1dea7c6f.1515086770.git.tim.c.chen@linux.intel.com> <1515150882.29312.114.camel@infradead.org> From: Tom Lendacky Message-ID: <197c55e4-4341-8151-6463-d2a91f0cc95b@amd.com> Date: Fri, 5 Jan 2018 09:14:40 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1515150882.29312.114.camel@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [165.204.78.1] X-ClientProxiedBy: DM5PR21CA0039.namprd21.prod.outlook.com (10.172.92.153) To MWHPR12MB1149.namprd12.prod.outlook.com (10.169.204.13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: e10cd47a-e1b5-4bae-6618-08d5544f0d97 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060);SRVR:MWHPR12MB1149; X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1149;3:E9qAc7J4c4fo5aRPgKNLxYHES4VU1QSpHFPhg34LV3vLv91ZOko3HSyXxAwaPSD7u63koL5xGZ8MUaohQqYWrGm7QsFeXzRC+NXfsvTeL8j5buEF/WRQsKkp96J6CggvLj4aeLRetO+uDQMW1U1V4tMMzB0NcfhQ6htgNGRFOmK3bdboZ+x8PQtdpfgCMwtLnW/601o2bsa+6Ebj8wEAFD0+HNmAh7XuEHDNWoFgAeA43r5deEFeQ5qsBmlRrG9R;25:HxLT1fLYXBT9RAp5GQsFmmSUEU59hbePk19eNWciZo0/09hH/wYr4QLotB1dW6tXE8XYCIPSeBvWujT2fTDjmPvMzIYj00naRB+D3KL35lSYIIEVbhYx5Q2xFNMiEpHnuO1c+D3pKrfyAC/HXUCjpdQg2j//A+Q09YxRSrephp61TD7jGvaP/HR8TjtYQE4NDROlir5fkOItFN6p9W0SjvfDZ4WnHN3Zasj81SSO49EYGRTrAOQ0fAxl8kw4S0RXh0bCpVq7fWqvKNCOSpvE56TdzslXxavapSUK6G44j1tnd/YY4A+bQqKJkyxgWCTCCA4KpyAbnX/p1x1umvXG6g==;31:RTywLs0GQGXjCfkc1ATxStP/BlUz/D08OxU/e25xD5B3eIKwjj5dHOa466TtRx6e83mU0iRn6nSan9PRfZiQ0pg41D4c2fornjf5eV1BJHVWJ14Y4xHtj/yj6XStZK0GlzbONBkD3YMWdbDSSMfFORkkPb+TWEAFg6/3m9yJf9lDiNLKqY5nWQOjL8j9/uzWTIEycqOZo2lcLioiT3xJZXzB3uU4XvXN6DThHXEGCaA= X-MS-TrafficTypeDiagnostic: MWHPR12MB1149: X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1149;20:czAjYHCBQJwQ/EsHwpQkCvQGnJd0to0Xb9yyKfEd70XmBlaZds4Dr8ysnvMLwzpgwj4Au1Ezx3N2jwShXu2eVmluPznLOipktuzwya8fhD2u82MFUbnGxQISnR51ey2x0B63trA2mKIxTDkZcE610u1y2LbuSTeYKQFR19i47GJ+erhLamqTtm4PxI8YsUeJ3jp3f72Vd2zPfzUd7HnxJHYflEYcDoW7+o0ukbmaNXoh7b8zsa+/njBpHGcPjfjvT9sdXBncPBbDkbako7W4EbGi6jDcyxL/J6NMrYl8Jf0jWqv7aZ0xSV+0IwSycDeg+hYXzz/7OsTaZxNKCVhCvaAw/z8kfVjcxeOjAVvKho2trNjfuubFJJo+B0RLaHxbkP5wiB+ZADZnHxBDAgLYLlZVrTfSGwghNGpKZCVxGiSUlFe06nhUXhkLIiPVMjvJX/CI9oWAlrZXC8tA/m/vjSeg/v4A4V49bBfXVoiAoIkm4OJRAhMf7y7dYpZHGZuv;4:IYAxbZnegzckK09VXaI9qP9dhX59QwBcIG5IIgy+1ER8Vi62bkUrg9pan7XyY+jkFN/ETRfYhbWAUcZYNEXDbDeGsq/H2gxfiP6rpLthvaOeank7sI7TOQRyBUVI0ZqA1KJ/TGvnAY/VTKz33VBkTNMvHnVKNgt+xggOPOqkV90n+k7498VqEq9eRRlUeXGZiouoHQNxNv6JkxOPtBD8FSh3sPNrdx19uNhrBl8/XBHjLsNiUUn5/7qmooum66yW7k6UAyBQ14mEL02Defs7hQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(8121501046)(5005006)(3231023)(944501075)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041268)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011);SRVR:MWHPR12MB1149;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:MWHPR12MB1149; X-Forefront-PRVS: 05437568AA X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(346002)(376002)(39380400002)(396003)(39860400002)(366004)(377424004)(199004)(189003)(24454002)(23676004)(53546011)(52116002)(59450400001)(31686004)(3260700006)(52146003)(64126003)(7736002)(65806001)(25786009)(6246003)(76176011)(66066001)(4326008)(86362001)(305945005)(106356001)(65956001)(5660300001)(53936002)(2906002)(7416002)(6116002)(386003)(47776003)(2486003)(3846002)(31696002)(229853002)(8676002)(2950100002)(6486002)(6666003)(77096006)(83506002)(50466002)(8936002)(316002)(72206003)(68736007)(478600001)(36756003)(65826007)(90366009)(54906003)(97736004)(110136005)(81166006)(16576012)(81156014)(58126008)(105586002)(2870700001)(16526018);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR12MB1149;H:[10.236.65.116];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjEyTUIxMTQ5OzIzOlFSMFdBaUl5RUF3eTFuYXFSV21MREdwcWp3?= =?utf-8?B?Ui9ocExBZmtseEJ6eFhCSmpkdm5Sb1haNUFLdW1GUDBtaE1CZ0tMcWZnaElt?= =?utf-8?B?SEZnVU8wZG5mTko2cEVadXVSN00zeFdDK3VIVUNsbU5sN0tSMGxmL0dDWFhn?= =?utf-8?B?eVdmZEpSNTNVQlJDbnQzaVRYQ29lcGlDUEdmOEM0Q29PUW5WOWkrSGlEMHNJ?= =?utf-8?B?SGtRbXAwR3dxZjJlTm9tREszakRYeDV0VU9BMlpUT0FYUnNUSURST3kzT2VT?= =?utf-8?B?K04yMGJpcnRsTkdaKzU2aDV4K3h5bi9kUW1yN2hHZ3J1OGRoVEd5dHJ4NGk4?= =?utf-8?B?S1p2Sk1RSDRteVIxS2JJQVR4OTdKdnJ5SjBWVzdyakxFUk5sWWhtQURzNk5R?= =?utf-8?B?WU54Tk8rSEVRMEkxMXhNV3VBR3hFNDhmeVIweDZzSmV2czhscFRLb0FCcUJM?= =?utf-8?B?MWZ6S2JiRFhrSXc5WkZQNG5kcjRlaFlBSzhnVDRZT1I2a2wxN3d1V2h4cWlv?= =?utf-8?B?L2FjZ0Y2TjNSZDdxc3U0SC9aZTI4aUJIZElHb0VGRDArYU9QaGxLQm9xd2Q5?= =?utf-8?B?SmZBdjNhNk41UFJ1MUJRWVI5d1RaRVo4S0NzQWtmNThxWlNrRVpGZTNKVkJR?= =?utf-8?B?RGdrZmpMOUUzbkRnT0IwY2gweUMwOWZoSHNiT21JUFVQVWJrSjY3dkFsUmZF?= =?utf-8?B?OWRjbUxhbm5GYUxkeGFXaU1WamppV1V6Qm9rSFhQK1AyN21kU05pUDZodnkv?= =?utf-8?B?TXRYL3ZPZFYwOVpBdVliVGVuTTBNVFNrSGhtblc3UzVlK3hCOTYrRU5DWVdK?= =?utf-8?B?VEs4ZkpOVzJiS04yVm5PTTF1TlVaU2lSMVpMOGk4WFFIeGplQWtYc215UXAv?= =?utf-8?B?TVQzTzB3WlMxS1pwWkNuTlloU0dJTSs4NGdhUEF5ckJTMzFMUXg2YXpjQmZO?= =?utf-8?B?VTFRUXk1NHVjQXdlTVZXdTVYYjZZNWRrSUpRbmhjTkNOSzBnZ2ZpL0ZqWGl5?= =?utf-8?B?Sk50SGJ4SGRYSjFkOENBbGZZWG5PWnhmL25Obm16ZFI0M2o0N1JBcnhIOFlG?= =?utf-8?B?ckYzemRaZVF2R05iUzhrUG83UE5uTDRaMFJSNW95Ynpyc2k1clc4YU1tbnVh?= =?utf-8?B?eVM2TUdPNndham5NampodXZkZmhEV3l3M0ZPWnAxOXBoWFhxWitNSmVKWTJG?= =?utf-8?B?TGxLKzdYSS9HMHUrZmcrWWUrK3R3c2lSTHRBazUraFgvYldEUVdzM2FOdXVS?= =?utf-8?B?SU5RYjJTRWJpOFBQM1JJRlRSZGd1dWtlRmNqL3EwbCtzRUs0V0wxNWxSZlpP?= =?utf-8?B?SGM5YUdpWmF3Zk13RkdESHZPa0E3ZDhoV2ZpNkRoM3J0Ykl1SWV4U1JybFNO?= =?utf-8?B?b1owR3p0cTBZbnkxUjJ3c2V2bkxNQWRjclNiVTNaRzU3cUMrTFhTYnQ0ZVo0?= =?utf-8?B?RHlTRHNmV25PWFF6ZkUzamdzTW9MdGxZclV3S2F0RWRYMUxDZWlKQWFUT2Fa?= =?utf-8?B?d3VvZEl1WWdIV1hHdkplVnp6bWxDQ1VvZHBGRCsrRFNzRjBENi9KY0h1TUI0?= =?utf-8?B?N1R6ZUIreHErNmpSVlFjYlU2M25UWG10V1E3UEtZTHEzVnVZdEpaTUFOUUVY?= =?utf-8?B?ditSSEZrZ215UVk2Wit3SzJrVmh0aXhRZDFSYy9YeDk0WkZqY0NZeDNMU3ls?= =?utf-8?B?SjhTZ2ZjL21QaFhDY2hKYnc5Q1RiMjkycmZscFdGdnNUTWFxVGtpSlpGTWgr?= =?utf-8?B?ZHp2aUYwUnREL1Z4ckt4TExCanVxZWdoY3crdHBRMlNydTRCdkNTWjRNUEJ1?= =?utf-8?B?RGJRZHlWZDZIRnBaU0lGSGxrdGNUZWR0S24vNlBTVmhLaEJwRkZ4LzhSQ3Ey?= =?utf-8?B?YVZkRFNMSU5VL3Ivcms2b0I0WXMzOVpwQzErTitIUkxpMFlrdG1ZT3R5aWdx?= =?utf-8?B?Z0J4OHhpbm1hNWovc3lRSXNna3VDMjdRbzk0WXRlWEo2SVhBdVFPaWkvRUJO?= =?utf-8?B?Y0JFVUl2V1d2ZFNuN09WcnMvMlBSbmFtdVUxSkVacGlaTjVRTmxvSG14eXk1?= =?utf-8?Q?WwrQ=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1149;6:D0ajT76J0ObD2bEpitm0Zeeb+9YORU7JtMiQ816d2jCuXNU45wXjahQbB4PIFp3r1cMUMmZ/68x3RB0mLdHaXr5EibHFRCCfnwxht+dfO99B2sXvY7QhDb5YU3krfEAjP7d8oT8SyOv/DTTobaygd6dyuaF/L6JeS7MMQZGVbDTAXEwZy00YunPbXw/K7u252VNNpB+bY4Yk7oTNkIEw6i7+zKFF0oVlOtEYD9HN+EQ8Zj/2tXbhxt278CVQaMNB2p3Fkew1HirtkMHW7HhAr6BTB5H9xZeCiS1jpbbXZWHNlaJPu+6Lgabhfk9sgd6+p9rZjc8nm4d1+tixU8+G40aYXLL3zC6iAhTjKYO74lc=;5:J8HF76eCMkO5oe83AJoJw3SKAE4Mf4awB0ULaJ3Yz6wvGErkBp3sFMiqNy/sqOOMe8Uw+IwA540xjApncuy19sv+NRzW7yx+AX2/dk/wleI3fSDoiJwAlAeg0MTGQsPcQOS+dTnzHPqjXLMa/4I3M18J44aK4vUd2oVVB40WXqg=;24:W51vBmjcDWGUlS9st/Te/du9eS46KzPq4WHeGpWBC4xLdFGuSjQT/XTJaeY5gfn8Le0BNRO4TKssSr42Qi6/rdLDFK1egtxO5A68/8hRyy8=;7:7PE7dlo1e/fpvP3h+AggYSygMloa08qsCRE57pHfWrDY9EbshcwkHW8tvddmAA6dA5CVzqysb6MXYTc1n56izruZaX2uFqv9TuBk8JbGxvV2p/r+mHU7x7vNDGKI/2xCW0Iu5rkY7P3KIRWX50xyfJNR/mN/eyHRiMUpjebwF58t4NMqBCIrcZXCdaf8+xjsdZsA++zX0HuYtMGBZorEcHAS1SZ2AMtHuwqQdX5XW5fMN3xaJBPeSJS4Zj7XLcAE SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1149;20:OAnRcJXZPGMWtRYV0DnNixyv+BjRg3fOFAklSOHZxCYlFtlRQipktZqjHBfLvZMSiOeU/EF5HKmhEUxLqK67eN9VF4QgqxImdCEHDstcRAdk+iHmcjyx27gEq3cy5NKhGNNU4w0v/JqsApMrMlS1Sy+GyJC8s8bNqbrbtm/O4SlV+NPBq3gZpvEO6z0VQGVyrw/zBm+pAjwyK8XvzUqDUasCjI3wVokl65mrf+1b1MEg/QX00WaXl34GrF86wedt X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2018 15:14:44.1374 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e10cd47a-e1b5-4bae-6618-08d5544f0d97 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1149 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 1/5/2018 5:14 AM, David Woodhouse wrote: > On Thu, 2018-01-04 at 09:56 -0800, Tim Chen wrote: >> cpuid ax=0x7, return rdx bit 26 to indicate presence of this feature >> IA32_SPEC_CTRL (0x48) and IA32_PRED_CMD (0x49) >> IA32_SPEC_CTRL, bit0 – Indirect Branch Restricted Speculation (IBRS) >> IA32_PRED_CMD,  bit0 – Indirect Branch Prediction Barrier (IBPB) > > In a previous iteration of these patches, hadn't you already merged > support for the AMD variant? Where'd that go? It looks like this series is strictly IBRS related. Even though some of the IBPB definitions are in here, there isn't support later for indicating IBPB is in use or any places where IBPB would be used. I was assuming that there would be another series for IBPB support. Is that the plan? AMD is covered by the IBRS support as is, but we also have support for the IBPB feature alone, identified by a different CPUID bit. I was waiting for the IBPB series to see if I needed to submit anything or whether the patches were included. Thanks, Tom >