Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752091AbeAEP42 (ORCPT + 1 other); Fri, 5 Jan 2018 10:56:28 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:33334 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751562AbeAEP41 (ORCPT ); Fri, 5 Jan 2018 10:56:27 -0500 Date: Fri, 05 Jan 2018 10:56:24 -0500 (EST) Message-Id: <20180105.105624.1086162210595261552.davem@davemloft.net> To: arnd@arndb.de Cc: saeedm@mellanox.com, matanb@mellanox.com, leonro@mellanox.com, ogerlitz@mellanox.com, hadarh@mellanox.com, paulb@mellanox.com, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net/mlx5e: hide an unused variable From: David Miller In-Reply-To: <20180103224022.3737385-1-arnd@arndb.de> References: <20180103224022.3737385-1-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 05 Jan 2018 07:56:26 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: From: Arnd Bergmann Date: Wed, 3 Jan 2018 23:40:11 +0100 > The uplink_rpriv variable was added at the start of the function but > only used inside of an #ifdef: > > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c: In function 'mlx5e_route_lookup_ipv6': > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c:1549:25: error: unused variable 'uplink_rpriv' [-Werror=unused-variable] > > This moves the declaration into that #ifdef as well. > > Fixes: 5ed99fb421d4 ("net/mlx5e: Move ethernet representors data into separate struct") > Signed-off-by: Arnd Bergmann Applied. Please make it clear which tree you are targetting in your Subject lines in the future. This should have been "[PATCH net-next] ...".