Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752604AbeAERKt (ORCPT + 1 other); Fri, 5 Jan 2018 12:10:49 -0500 Received: from mx2.suse.de ([195.135.220.15]:40204 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752410AbeAERKr (ORCPT ); Fri, 5 Jan 2018 12:10:47 -0500 Date: Fri, 5 Jan 2018 09:04:47 -0800 From: Davidlohr Bueso To: kernel test robot Cc: acme@kernel.org, jolsa@redhat.com, ak@linux.intel.com, mingo@redhat.com, linux-kernel@vger.kernel.org, Davidlohr Bueso , lkp@01.org Subject: Re: [lkp-robot] [perf machine] 8edf8850d5: stderr./usr/src/linux-perf-x86_64-rhel-#/tools/perf/util/rb_resort.h:#:#:error:passing_argument#of'threads_sorted__new'from_incompatible_pointer_type[-Werror=incompatible-pointer-types] Message-ID: <20180105170447.kcpuwmaspespxdv2@linux-n805> References: <20171127023046.19139-3-dave@stgolabs.net> <20180104055110.GC23834@yexl-desktop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20180104055110.GC23834@yexl-desktop> User-Agent: NeoMutt/20170421 (1.8.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Thu, 04 Jan 2018, kernel test robot wrote: >[ 68.830934] /usr/src/linux-perf-x86_64-rhel-7.2-8edf8850d51e911a35b5d7aad4f8604db11abc66/tools/perf/util/rb_resort.h:148:28: error: passing argument 1 of 'threads_sorted__new' from incompatible pointer type [-Werror=incompatible-pointer-types] I didn't have libaudit so I wasn't building builtin-trace, which obviously needs fixed. Arnaldo, dunno if you're taking this series, but please let me know if you want a v2 or you can fold the below fix into this patch. Thanks, Davidlohr diff --git a/tools/perf/util/rb_resort.h b/tools/perf/util/rb_resort.h index a920f702a74d..aa7a63628d75 100644 --- a/tools/perf/util/rb_resort.h +++ b/tools/perf/util/rb_resort.h @@ -140,12 +140,12 @@ struct __name##_sorted *__name = __name##_sorted__new /* For 'struct intlist' */ #define DECLARE_RESORT_RB_INTLIST(__name, __ilist) \ - DECLARE_RESORT_RB(__name)(&__ilist->rblist.entries, \ + DECLARE_RESORT_RB(__name)(&__ilist->rblist.entries.rb_root, \ __ilist->rblist.nr_entries) /* For 'struct machine->threads' */ #define DECLARE_RESORT_RB_MACHINE_THREADS(__name, __machine, hash_bucket) \ - DECLARE_RESORT_RB(__name)(&__machine->threads[hash_bucket].entries, \ + DECLARE_RESORT_RB(__name)(&__machine->threads[hash_bucket].entries.rb_root,\ __machine->threads[hash_bucket].nr) #endif /* _PERF_RESORT_RB_H_ */