Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752572AbeAETCl (ORCPT + 1 other); Fri, 5 Jan 2018 14:02:41 -0500 Received: from mail-oi0-f67.google.com ([209.85.218.67]:40616 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752166AbeAETCj (ORCPT ); Fri, 5 Jan 2018 14:02:39 -0500 X-Google-Smtp-Source: ACJfBotElKa2ceo6rsJa92u5NK5Crr1VEd4HTe3cCUbOBAK5BX7/nqeiQ4NWS/U7ViLqjSstdc4exg== Date: Fri, 5 Jan 2018 13:02:36 -0600 From: Rob Herring To: Ryder Lee Cc: Stephen Boyd , Mark Brown , Lee Jones , Matthias Brugger , linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Garlic Tseng Subject: Re: [PATCH v1 4/6] dt-bindings: clock: mediatek: add "simple-mfd" in audsys documentation Message-ID: <20180105190236.bapetnwxd6dii7re@rob-hp-laptop> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Thu, Jan 04, 2018 at 03:44:20PM +0800, Ryder Lee wrote: > Add "simple-mfd" to support MFD device and add a compatible string for MT2701. > > Signed-off-by: Ryder Lee > --- > .../bindings/arm/mediatek/mediatek,audsys.txt | 21 +++++++++++++++------ > 1 file changed, 15 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.txt > index 9b8f578..6e97552 100644 > --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.txt > +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.txt > @@ -6,17 +6,25 @@ The MediaTek AUDSYS controller provides various clocks to the system. > Required Properties: > > - compatible: Should be one of: > - - "mediatek,mt7622-audsys", "syscon" > + - "mediatek,mt2701-audsys", "syscon", "simple-mfd" > + - "mediatek,mt7622-audsys", "syscon", "simple-mfd" > - #clock-cells: Must be 1 I don't think this is a simple-mfd. The AFE uses clocks created by its parent, right? So the parent should be probed first. You should have the parent instantiate the child nodes. > The AUDSYS controller uses the common clk binding from > Documentation/devicetree/bindings/clock/clock-bindings.txt > The available clocks are defined in dt-bindings/clock/mt*-clk.h. > > +See ../sound/mt2701-afe-pcm.txt for details about required subnode. > + > Example: > > -audsys: audsys@11220000 { > - compatible = "mediatek,mt7622-audsys", "syscon"; > - reg = <0 0x11220000 0 0x1000>; > - #clock-cells = <1>; > -}; > + audsys: audio-subsystem@11220000 { > + compatible = "mediatek,mt2701-audsys", "syscon", "simple-mfd"; > + reg = <0 0x11220000 0 0x1000>; > + #clock-cells = <1>; > + > + afe: audio-controller { > + compatible = "mediatek,mt2701-audio"; > + ... > + }; > + }; > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html