Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753065AbeAEU4L (ORCPT + 1 other); Fri, 5 Jan 2018 15:56:11 -0500 Received: from mout.web.de ([212.227.17.11]:49444 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752822AbeAEU4J (ORCPT ); Fri, 5 Jan 2018 15:56:09 -0500 To: linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Alexandre Belloni , Boris Brezillon , Brian Norris , Cyrille Pitchen , David Woodhouse , Josh Wu , Marek Vasut , Nicolas Ferre , Richard Weinberger , Wenyou Yang From: SF Markus Elfring Subject: [PATCH] mtd/nand/atmel: Delete an error message for a failed memory allocation in two functions Cc: LKML , kernel-janitors@vger.kernel.org Message-ID: <81cadb76-8c67-9289-1375-2d4a55a4adfa@users.sourceforge.net> Date: Fri, 5 Jan 2018 21:55:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:oTXKqvqMdR63rC3bOn8ghTYVB91Og51WDGu7zcKfTkHwkGU3/z4 Wj/Tz7wi4PWxZXcn2VtN/kUzfFjzDLoX/uc62QWhv1lAnuo6EEQfRI2xul1DQ2lCIa5oMmC akHqczF6ccrLMGwkAwiZOIM293yYXw/v+w01hx9KzQxpnGkAOqh0kXXm5sxRxzt5u2cO8RN RbOtew/ThEjHbyj20EGYA== X-UI-Out-Filterresults: notjunk:1;V01:K0:lb9+Vi//w8E=:0tJF0JkJ0sC/9SdK1d6vsU 9RXofo5uow8/1tM7rE5UDay9EGPuFM4hKyeMpnRlNcE2UrW9gLWBr2Esl0NAieQIcvkfRwVhd XvVzPt1VaRVCulV6klzhU3IkAyqn/K02M34eMUQ3xbMklCV4feTIrwCemVJonHWjJd4BpJ6jh JyrgfwehkNnF84UeyDEbthLFZp0e+2cDWtuB+XAcuYWpcmngZsIWNxmDkNiIzOkDVESiVex9/ biZv6f+wA83lAkGIB5j3/DZO5xAFaY+NS7IKFpKDoH/cx7SmOT7/ER6WCNM+PDaM9vyoxx0wK EHT7+nPeHP9SgGsmC8uX6DtD70YjxGJrUV9M6z33Ef1TZlbH7VBkqbB7VtbbyqRM6Toc44lak 7gAg2uR1UILe1NGpJx6cjV1pTbWJdMf40VYXg3Q73//Xj+8Lmgzjux2oITl5bQYzBM6M6QEue 9pdN/qRJZa6fvxZgafXAZ98raf0P8g58WgfNgRa2xRoLE5t7+0sUzNv/cfCD4aiKtlW2jJwOD YGPkGQ8Y7+1V3lF6TFJ1UsttqbjiW7Wr+9p0smJyaU+KapMbiwg9b98CoT6dhgeD3BExnmhqg YZvkTFf0Wc2UZvB3TQdg0B8lI9ifgQ9ojfhN3bR/7nrl1VXILND1QgGhC4fkcCgJjZsU1T6HE 4UyGfgOUA4kXc90p6XTA5/P0KdP0qn1xTBRXexUTZQAbD1ObzMOK2I+fiJzJa0ca+hPk+kS8V PUQVA9iN+Ot4VH87CyJG3DprAIR2ixiUb8kxKSd2eoEPqOPnUas0FBbcZEk0eVlAOnAkEe+Gq NefJu5VLLwjA3IopfftEeBSDgwzOjl7vHQ6NYQcAa0kSTP2zbY= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: From: Markus Elfring Date: Fri, 5 Jan 2018 21:45:04 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/mtd/nand/atmel/nand-controller.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/mtd/nand/atmel/nand-controller.c b/drivers/mtd/nand/atmel/nand-controller.c index 90a71a56bc23..a41b999229c9 100644 --- a/drivers/mtd/nand/atmel/nand-controller.c +++ b/drivers/mtd/nand/atmel/nand-controller.c @@ -1612,10 +1612,8 @@ static int atmel_nand_register(struct atmel_nand *nand) mtd->name = devm_kasprintf(nc->dev, GFP_KERNEL, "%s:nand.%d", dev_name(nc->dev), nand->cs[0].id); - if (!mtd->name) { - dev_err(nc->dev, "Failed to allocate mtd->name\n"); + if (!mtd->name) return -ENOMEM; - } } ret = nand_scan_tail(mtd); @@ -1654,10 +1652,8 @@ static struct atmel_nand *atmel_nand_create(struct atmel_nand_controller *nc, nand = devm_kzalloc(nc->dev, sizeof(*nand) + (numcs * sizeof(*nand->cs)), GFP_KERNEL); - if (!nand) { - dev_err(nc->dev, "Failed to allocate NAND object\n"); + if (!nand) return ERR_PTR(-ENOMEM); - } nand->numcs = numcs; -- 2.15.1