Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753150AbeAEVnC (ORCPT + 1 other); Fri, 5 Jan 2018 16:43:02 -0500 Received: from mail-qk0-f195.google.com ([209.85.220.195]:37454 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753074AbeAEVnA (ORCPT ); Fri, 5 Jan 2018 16:43:00 -0500 X-Google-Smtp-Source: ACJfBov9ywXHr3nqqI492ppugxoB/3i945FGJhQgpFQTueC6BAVEJ9dhLSJnCcQEGWcdtV0khFwfXA== Date: Fri, 5 Jan 2018 16:42:58 -0500 (EST) From: Nicolas Pitre To: Bartlomiej Zolnierkiewicz cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] console/dummy: leave .con_font_get set to NULL Message-ID: User-Agent: Alpine 2.21 (LFD 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: When this method is set, the caller expects struct console_font fields to be properly initialized when it returns. Leave it unset otherwise nonsensical (leaked kernel stack) values are returned to user space. Signed-off-by: Nicolas Pitre Cc: stable@kernel.org diff --git a/drivers/video/console/dummycon.c b/drivers/video/console/dummycon.c index 9269d56852..b90ef96e43 100644 --- a/drivers/video/console/dummycon.c +++ b/drivers/video/console/dummycon.c @@ -67,7 +67,6 @@ const struct consw dummy_con = { .con_switch = DUMMY, .con_blank = DUMMY, .con_font_set = DUMMY, - .con_font_get = DUMMY, .con_font_default = DUMMY, .con_font_copy = DUMMY, };